Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react-element-to-jsx-string #882

Merged
merged 2 commits into from
Jan 27, 2021

Conversation

michaeltaranto
Copy link
Contributor

Upgrading react-element-to-jsx-string to fix the bug where opening Playroom links from the docs site may not preserve white space as expected.

This bug was fixed which means white space is preserved as expected when opening the Job Summary for example.

Clicking on the Open in Playroom button:
Before: Link
After: Link

Previously collapses the white space between the classification icon and text.

@michaeltaranto michaeltaranto requested a review from a team as a code owner January 27, 2021 23:49
@changeset-bot
Copy link

changeset-bot bot commented Jan 27, 2021

⚠️ No Changeset found

Latest commit: 3234705

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@mattcompiles mattcompiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They added types as well?

@michaeltaranto
Copy link
Contributor Author

Added types in 2019 and fixed some bugs in Jan 2020 we just never updated.

@michaeltaranto michaeltaranto merged commit 115bdb4 into master Jan 27, 2021
@michaeltaranto michaeltaranto deleted the update-react-element-to-jsx-string branch January 27, 2021 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants