-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xWidthAvg: Add subset
support for non-latin character sets
#177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9d7ae2f The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
askoufis
reviewed
Feb 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Adam Skoufis <askoufis@users.noreply.github.com>
askoufis
reviewed
Feb 28, 2024
askoufis
reviewed
Feb 28, 2024
michaeltaranto
force-pushed
the
add-subset-support
branch
from
March 4, 2024 02:16
4bbcacb
to
c1d1e73
Compare
michaeltaranto
force-pushed
the
add-subset-support
branch
from
March 4, 2024 02:16
c1d1e73
to
186780f
Compare
askoufis
reviewed
Mar 8, 2024
Co-authored-by: Adam Skoufis <askoufis@users.noreply.github.com>
askoufis
approved these changes
Mar 8, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xWidthAvg: Add
subset
support for non-latin character setsPreviously the
xWidthAvg
metric was calculated based on the character frequency as measured from English text only.This resulted in the
xWidthAvg
metric being incorrect for languages that use a different unicode subset range, e.g. Thai.Supporting Thai now enables adding support for other unicode ranges in the future.
What's changed?
@capsizecss/metrics
The
subsets
field has been added to the metrics object, providing thexWidthAvg
metric for each subset — calculated against the relevant character frequency data.There are no changes to any of the other existing metrics.
@capsizecss/core
Fallback font stacks can now be generated per subset, allowing the correct
xWidthAvg
metric to be used for the relevant subset.The
createFontStack
API now acceptssubset
as an option: