Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable resolving node_modules from the root of the repo #119

Merged
merged 3 commits into from
Jul 6, 2023
Merged

Disable resolving node_modules from the root of the repo #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
44c4c25
bump deps & use Node.js 18
mrm007 Jul 6, 2023
abebb23
extend react/jsx-runtime
mrm007 Jul 6, 2023
1da74cc
disable resolving `node_modules` from the root of the repo
mrm007 Jul 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/lemon-moles-pretend.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'eslint-config-seek': minor
---

Extend `react/jsx-runtime`, since we are now using the [JSX transform](https://legacy.reactjs.org/blog/2020/09/22/introducing-the-new-jsx-transform.html)
5 changes: 5 additions & 0 deletions .changeset/modern-windows-nail.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'eslint-config-seek': patch
---

Update dependencies
5 changes: 5 additions & 0 deletions .changeset/sixty-days-sort.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'eslint-config-seek': patch
---

Disable resolving `node_modules` from the root of the repo. This is problematic for JavaScript-only monorepos (where there are multiple `node_modules` directories).
2 changes: 1 addition & 1 deletion base.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ const baseConfig = {
settings: {
'import/resolver': {
node: {
moduleDirectory: [root, path.join(root, 'node_modules')],
moduleDirectory: [root, 'node_modules'],
},
},
},
Expand Down
6 changes: 5 additions & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,11 @@ const eslintConfig = {
},
},
plugins: ['react', 'react-hooks'],
extends: ['plugin:react/recommended', './base.js'],
extends: [
'plugin:react/recommended',
'plugin:react/jsx-runtime',
'./base.js',
],
parserOptions: {
babelOptions: {
presets: [require.resolve('@babel/preset-react')],
Expand Down
26 changes: 13 additions & 13 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,34 +25,34 @@
},
"homepage": "https://github.com/seek-oss/eslint-config-seek#readme",
"dependencies": {
"@babel/core": "^7.21.0",
"@babel/eslint-parser": "^7.19.1",
"@babel/preset-react": "^7.18.6",
"@babel/core": "^7.22.6",
"@babel/eslint-parser": "^7.22.6",
"@babel/preset-react": "^7.22.5",
"@finsit/eslint-plugin-cypress": "^3.1.1",
"@typescript-eslint/eslint-plugin": "^5.53.0",
"@typescript-eslint/parser": "^5.53.0",
"eslint-config-prettier": "^8.6.0",
"eslint-import-resolver-typescript": "3.5.3",
"@typescript-eslint/eslint-plugin": "^5.61.0",
"@typescript-eslint/parser": "^5.61.0",
"eslint-config-prettier": "^8.8.0",
"eslint-import-resolver-typescript": "3.5.5",
"eslint-plugin-import": "^2.27.5",
"eslint-plugin-jest": "^27.2.1",
"eslint-plugin-jest": "^27.2.2",
"eslint-plugin-react": "^7.32.2",
"eslint-plugin-react-hooks": "^4.6.0",
"eslint-plugin-rulesdir": "^0.2.2",
"find-root": "^1.1.0"
},
"devDependencies": {
"@changesets/cli": "^2.26.0",
"@changesets/cli": "^2.26.2",
"@changesets/get-github-info": "^0.5.2",
"eslint": "^8.34.0",
"eslint": "^8.44.0",
"prettier": "^2.8.4",
"typescript": "~4.9.5"
"typescript": "~5.1.6"
},
"peerDependencies": {
"eslint": ">=6",
"typescript": ">=4.5"
},
"packageManager": "pnpm@8.5.1",
"packageManager": "pnpm@8.6.6",
"volta": {
"node": "16.19.1"
"node": "18.12.1"
}
}
Loading