Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop CSS Modules and Flow plugins #64

Merged
merged 4 commits into from
Nov 11, 2021
Merged

Drop CSS Modules and Flow plugins #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e48e335
Migrate to Changesets
72636c Oct 25, 2021
36fe856
Drop CSS Modules and Flow plugins
72636c Oct 25, 2021
f0309c7
Merge branch 'master' into drop-old-fe-plugins
72636c Oct 26, 2021
64c3b28
Merge branch 'master' into drop-old-fe-plugins
72636c Nov 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .changeset/cuddly-ears-hide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
'eslint-config-seek': major
---

Remove support for Flow

SEEK has aligned on [TypeScript](https://www.typescriptlang.org/) for static type checking. [Flow](https://flow.org/) support was similarly removed in [sku 11](https://github.com/seek-oss/sku/releases/tag/v11.0.0).

Affected projects should migrate to TypeScript.
9 changes: 9 additions & 0 deletions .changeset/wild-suits-float.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
'eslint-config-seek': major
---

Remove support for CSS Modules

[eslint-plugin-css-modules](https://github.com/atfzl/eslint-plugin-css-modules) is unmaintained, and SEEK has since moved on to [vanilla-extract](https://vanilla-extract.style/).

Affected projects should migrate to vanilla-extract.
10 changes: 2 additions & 8 deletions .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,12 +100,8 @@ const baseConfig = {
version: '>16',
},
},
plugins: ['react', 'react-hooks', 'css-modules'],
extends: [
'plugin:css-modules/recommended',
'plugin:react/recommended',
'prettier',
],
plugins: ['react', 'react-hooks'],
extends: ['plugin:react/recommended', 'prettier'],
rules: {
...baseRules,
...reactRules,
Expand Down Expand Up @@ -159,7 +155,6 @@ const baseConfig = {
es6: true,
},
extends: [
'plugin:flowtype/recommended',
'plugin:import/errors',
'plugin:import/warnings',
'plugin:import/typescript',
Expand All @@ -171,7 +166,6 @@ const baseConfig = {
},
},
},
plugins: ['flowtype'],
rules: {
'no-use-before-define': [ERROR, { functions: false }],
'no-unused-expressions': ERROR,
Expand Down
2 changes: 0 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,7 @@
"babel-eslint": "^10.1.0",
"eslint-config-prettier": "^6.11.0",
"eslint-import-resolver-node": "^0.3.3",
"eslint-plugin-css-modules": "^2.11.0",
"eslint-plugin-cypress": "^2.11.1",
"eslint-plugin-flowtype": "^5.1.3",
"eslint-plugin-import": "^2.21.2",
"eslint-plugin-jest": "^25.2.2",
"eslint-plugin-react": "^7.20.0",
Expand Down