This repository has been archived by the owner on Apr 11, 2024. It is now read-only.
test: Fix Jest localStorage warning, fix invalid hex codes #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to investigate a potential issue with
data-sketch-color, but immediately ran into issues where the test suite was failing with the following message:The fix was to set
testEnvironmenttonodein the Jest config.After fixing this, I noticed that we actually had some invalid hex codes in our test suite, which was resulting in unexpected document colours. I've update the hex codes and the snapshots, and verified that the colours show up correctly when importing into Sketch.
Luckily, as far as
data-sketch-colorgoes, I wasn't able to find any issues.