-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
start
script: reuse tab if possible in more Chromium browsers
#1036
Conversation
🦋 Changeset detectedLatest commit: 1fec957 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Refactor from PR suggestions Co-authored-by: Adam Skoufis <askoufis@users.noreply.github.com>
358b037
to
2b48ae7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on my machine, works great! Just 1 comment, also the PR needs a changeset.
02e209e
to
68cac4d
Compare
Co-authored-by: Adam Skoufis <askoufis@users.noreply.github.com>
sku
will reuse an existing tab if available in more Chromium browsers.If the user's default browser is not Chromium based, there will be no change. If it is Chromium based, and the user has multiple supported Chromium browsers installed, the tab will open (or be reused) in:
Using default-browser package instead of x-default-browser as it has support for Microsoft Edge and is more widely used.
NB:
This PR is heavily based on the changes from this PR, referenced here.
It is an update to #426.