Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start script: reuse tab if possible in more Chromium browsers #1036

Merged
merged 9 commits into from
Aug 20, 2024

Conversation

felixhabib
Copy link
Contributor

@felixhabib felixhabib commented Aug 19, 2024

sku will reuse an existing tab if available in more Chromium browsers.

If the user's default browser is not Chromium based, there will be no change. If it is Chromium based, and the user has multiple supported Chromium browsers installed, the tab will open (or be reused) in:

  • The user's default browser, if it is open, or if no browsers are open.
  • Another supported browser, if it is open and the default browser is not open.

Using default-browser package instead of x-default-browser as it has support for Microsoft Edge and is more widely used.

NB:

This PR is heavily based on the changes from this PR, referenced here.
It is an update to #426.

@felixhabib felixhabib requested a review from a team as a code owner August 19, 2024 03:56
Copy link

changeset-bot bot commented Aug 19, 2024

🦋 Changeset detected

Latest commit: 1fec957

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
sku Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@felixhabib felixhabib marked this pull request as draft August 19, 2024 03:57
@felixhabib felixhabib marked this pull request as ready for review August 19, 2024 03:58
packages/sku/lib/openBrowser/index.js Outdated Show resolved Hide resolved
packages/sku/lib/openBrowser/index.js Outdated Show resolved Hide resolved
packages/sku/lib/openBrowser/index.js Show resolved Hide resolved
@felixhabib felixhabib marked this pull request as draft August 19, 2024 05:10
felixhabib and others added 2 commits August 19, 2024 15:11
Refactor from PR suggestions

Co-authored-by: Adam Skoufis <askoufis@users.noreply.github.com>
@felixhabib felixhabib marked this pull request as ready for review August 19, 2024 07:11
Copy link
Contributor

@askoufis askoufis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my machine, works great! Just 1 comment, also the PR needs a changeset.

packages/sku/lib/openBrowser/index.js Outdated Show resolved Hide resolved
Co-authored-by: Adam Skoufis <askoufis@users.noreply.github.com>
@felixhabib felixhabib enabled auto-merge (squash) August 20, 2024 01:31
@felixhabib felixhabib merged commit 16fdf5e into master Aug 20, 2024
4 checks passed
@felixhabib felixhabib deleted the open-edge-one-tab branch August 20, 2024 01:36
@seek-oss-ci seek-oss-ci mentioned this pull request Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants