Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HTTPS URL for zendesk/babel-plugin-react-displayname dependency #1039

Merged
merged 2 commits into from
Sep 2, 2024

Conversation

askoufis
Copy link
Contributor

@askoufis askoufis commented Aug 26, 2024

It has been observed internally that PNPM will sometimes replace the artifact URL for a github dependency with an SSH URL.

The only relevant PNPM issue I could find was pnpm/pnpm#4527. I'm not sure if this fix on sku's end will actually prevent it from happening again because the resolution of the dependency is in PNPM's hands, but it's worth a shot.

… to hopefully prevent it from being cloned via SSH
@askoufis askoufis requested a review from a team as a code owner August 26, 2024 00:26
Copy link

changeset-bot bot commented Aug 26, 2024

🦋 Changeset detected

Latest commit: 533b224

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
sku Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@michaeltaranto michaeltaranto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

@askoufis askoufis enabled auto-merge (squash) September 2, 2024 05:18
@askoufis askoufis merged commit c17dc0f into master Sep 2, 2024
4 checks passed
@askoufis askoufis deleted the https-git-dep branch September 2, 2024 05:22
@seek-oss-ci seek-oss-ci mentioned this pull request Sep 2, 2024
askoufis added a commit that referenced this pull request Sep 16, 2024
askoufis added a commit that referenced this pull request Sep 16, 2024
askoufis added a commit that referenced this pull request Sep 16, 2024
@askoufis askoufis mentioned this pull request Sep 16, 2024
askoufis added a commit that referenced this pull request Sep 16, 2024
@seek-oss-ci seek-oss-ci mentioned this pull request Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants