fix(test): Support dynamic imports in tests #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chardos
approved these changes
Apr 1, 2019
kosanna
reviewed
Apr 1, 2019
| @@ -19,25 +19,25 @@ SOURCE HTML: | |||
| <link data-chunk="handlers-Home" | |||
| rel="preload" | |||
| as="script" | |||
| href="http://localhost:4004/handlers-Home-9299312b46da1275b24f.js" | |||
| href="http://localhost:4004/handlers-Home-d4afda529b3b1a8b8da7.js" | |||
There was a problem hiding this comment.
Because the script contents changed, it's changed the hash in the snapshot tests.
michaeltaranto
approved these changes
Apr 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
sku test, we need to ensure that dynamicimport()calls are compiled correctly for node, which we do with babel-plugin-dynamic-import-node.