Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webpack-dev-server): Lock version to 3.2.1 #348

Merged
merged 1 commit into from
Apr 16, 2019

Conversation

mattcompiles
Copy link
Contributor

There is an issue with the latest version of webpack-dev-server (v3.3.1) working in sku. We should look at this issue but I think it may be on their end. Either way this PR ensures users don't upgrade and get errors.

Example error.

$ npm start

> my-app@0.1.0 start /Users/gkljajic/projects/my-app
> sku start


Starting the development server on http://localhost:8080/

ℹ 「wdm」: wait until bundle finished: /
🚨 HtmlRenderPlugin: An error occured rendering HTML ReferenceError: self is not defined
    at Object.eval (webpack://static/(webpack)-dev-server/client?:51:19)
    at eval (webpack://static/(webpack)-dev-server/client?:299:30)
    at Object../node_modules/webpack-dev-server/client/index.js?http://localhost (render.js:2532:1)
    at __webpack_require__ (render.js:30:30)
    at eval (webpack://static/multi_(webpack)-dev-server/client?:1:1)
    at Object.0 (render.js:2624:1)
    at __webpack_require__ (render.js:30:30)
    at render.js:94:18
    at render.js:97:10
    at webpackUniversalModuleDefinition (render.js:3:20)
✖ 「wdm」: Child client:

    ERROR in html-render-webpack-plugin: An error occured during render:
    ReferenceError: self is not defined
ℹ 「wdm」: Failed to compile.

@mattcompiles mattcompiles requested a review from a team as a code owner April 11, 2019 23:26
@mattcompiles mattcompiles merged commit dc4ad1b into master Apr 16, 2019
@mattcompiles mattcompiles deleted the lock-webpack-dev-server branch April 16, 2019 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants