Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

template: @types/supertest ^6.0.0 #1366

Merged
merged 12 commits into from
Jan 3, 2024
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 2, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@types/supertest (source) ^2.0.11 -> ^6.0.0 age adoption passing confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Configuration

📅 Schedule: Branch creation - "after 3:00 am and before 6:00 am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

Copy link

changeset-bot bot commented Jan 2, 2024

🦋 Changeset detected

Latest commit: 8231974

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
skuba Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@renovate renovate bot requested review from a team as code owners January 2, 2024 22:58
Copy link
Contributor Author

renovate bot commented Jan 2, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@72636c
Copy link
Member

72636c commented Jan 2, 2024

I'll see if I can tweak the test-template script any further. It looks like the templates end up hoisting the old eslint-config-skuba version which is why CI is still failing.

Copy link
Contributor

@AaronMoat AaronMoat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would the jest thing be better handled in npmrc?

@72636c
Copy link
Member

72636c commented Jan 3, 2024

@AaronMoat it's already there, but I think hoisting goes wonky with local links 🤷

$ cat ../tmp-koa-rest-api/.npmrc

# managed by skuba
public-hoist-pattern[]=@types*
public-hoist-pattern[]=*eslint*
public-hoist-pattern[]=*prettier*
public-hoist-pattern[]=tsconfig-seek
# end managed by skuba

Copy link
Contributor

@AaronMoat AaronMoat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gross! But pragmatic.

@72636c 72636c merged commit d33ea76 into master Jan 3, 2024
19 checks passed
@72636c 72636c deleted the renovate-template-supertest-6.x branch January 3, 2024 01:50
@seek-oss-ci seek-oss-ci mentioned this pull request Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants