-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix package manager detection #1552
Merged
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
8877310
Fix package manager detection
AaronMoat 02d4e5c
Run `skuba format`
seek-oss-ci f40b5ef
pnpmify after bug is fixed
AaronMoat dfc2ffe
changesets
AaronMoat ce96e62
Remove .npmrc
AaronMoat 25b4f80
Gitignore .npmrc
AaronMoat 80df158
Merge remote-tracking branch 'origin/main' into pm
AaronMoat File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'skuba': minor | ||
--- | ||
|
||
lint: Add coverage to .prettierignore |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
--- | ||
'skuba': minor | ||
--- | ||
|
||
lint: Swap out `detect-package-manager` for manual lockfile detection | ||
|
||
`detect-package-manager` has been removed, in lieu of using `find-up` to detect the closest | ||
`pnpm-lock.yaml` or `yarn.lock` to infer the package manager. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,6 +5,7 @@ | |
gantry*.yaml | ||
gantry*.yml | ||
pnpm-lock.yaml | ||
coverage | ||
# end managed by skuba | ||
|
||
/integration/base/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
# managed by skuba | ||
public-hoist-pattern[]="@types*" | ||
public-hoist-pattern[]="*eslint*" | ||
public-hoist-pattern[]="*prettier*" | ||
public-hoist-pattern[]="esbuild" | ||
public-hoist-pattern[]="jest" | ||
public-hoist-pattern[]="tsconfig-seek" | ||
# end managed by skuba |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,4 +5,5 @@ | |
gantry*.yaml | ||
gantry*.yml | ||
pnpm-lock.yaml | ||
coverage | ||
# end managed by skuba |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
# managed by skuba | ||
public-hoist-pattern[]="@types*" | ||
public-hoist-pattern[]="*eslint*" | ||
public-hoist-pattern[]="*prettier*" | ||
public-hoist-pattern[]="esbuild" | ||
public-hoist-pattern[]="jest" | ||
public-hoist-pattern[]="tsconfig-seek" | ||
# end managed by skuba |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,4 +5,5 @@ | |
gantry*.yaml | ||
gantry*.yml | ||
pnpm-lock.yaml | ||
coverage | ||
# end managed by skuba |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These might break changesets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean in consuming repos or in skuba itself?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
they did indeed break changesets, was able to get a snapshot running on a branch off this (with a dive changeset) https://github.com/seek-oss/skuba/actions/runs/8892072630