Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix package manager detection #1552

Merged
merged 7 commits into from
May 6, 2024
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/slow-moose-smoke.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'skuba': minor
---

lint: Add coverage to .prettierignore
8 changes: 8 additions & 0 deletions .changeset/ten-pets-hug.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
'skuba': minor
---

lint: Swap out `detect-package-manager` for manual lockfile detection

`detect-package-manager` has been removed, in lieu of using `find-up` to detect the closest
`pnpm-lock.yaml` or `yarn.lock` to infer the package manager.
1 change: 1 addition & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
gantry*.yaml
gantry*.yml
pnpm-lock.yaml
coverage
# end managed by skuba

/integration/base/
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@
"@types/node": ">=18.12",
"chalk": "^4.1.0",
"concurrently": "^8.0.0",
"detect-package-manager": "^3.0.1",
"dotenv": "^16.0.0",
"ejs": "^3.1.6",
"enquirer": "^2.3.6",
Expand All @@ -86,6 +85,7 @@
"eslint-config-skuba": "workspace:*",
"execa": "^5.0.0",
"fast-glob": "^3.3.2",
"find-up": "^5.0.0",
"fs-extra": "^11.0.0",
"function-arguments": "^1.0.9",
"get-port": "^5.1.1",
Expand Down
8 changes: 8 additions & 0 deletions packages/eslint-config-skuba/.npmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# managed by skuba
public-hoist-pattern[]="@types*"
public-hoist-pattern[]="*eslint*"
public-hoist-pattern[]="*prettier*"
public-hoist-pattern[]="esbuild"
public-hoist-pattern[]="jest"
public-hoist-pattern[]="tsconfig-seek"
# end managed by skuba
1 change: 1 addition & 0 deletions packages/eslint-config-skuba/.prettierignore
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,5 @@
gantry*.yaml
gantry*.yml
pnpm-lock.yaml
coverage
# end managed by skuba
6 changes: 0 additions & 6 deletions packages/skuba-dive/.dockerignore
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,3 @@ node_modules*/
npm-debug.log
yarn-error.log
# end managed by skuba

# Ignore .npmrc. This is no longer managed by skuba as pnpm projects use a managed .npmrc.
# IMPORTANT: if migrating to pnpm, remove this line and add an .npmrc IN THE SAME COMMIT.
# You can use `skuba format` to generate the file or otherwise commit an empty file.
# Doing so will conflict with a local .npmrc and make it more difficult to unintentionally commit auth secrets.
.npmrc
6 changes: 0 additions & 6 deletions packages/skuba-dive/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,3 @@ npm-debug.log
package-lock.json
yarn-error.log
# end managed by skuba

# Ignore .npmrc. This is no longer managed by skuba as pnpm projects use a managed .npmrc.
# IMPORTANT: if migrating to pnpm, remove this line and add an .npmrc IN THE SAME COMMIT.
# You can use `skuba format` to generate the file or otherwise commit an empty file.
# Doing so will conflict with a local .npmrc and make it more difficult to unintentionally commit auth secrets.
.npmrc
8 changes: 8 additions & 0 deletions packages/skuba-dive/.npmrc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These might break changesets

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean in consuming repos or in skuba itself?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they did indeed break changesets, was able to get a snapshot running on a branch off this (with a dive changeset) https://github.com/seek-oss/skuba/actions/runs/8892072630

Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# managed by skuba
public-hoist-pattern[]="@types*"
public-hoist-pattern[]="*eslint*"
public-hoist-pattern[]="*prettier*"
public-hoist-pattern[]="esbuild"
public-hoist-pattern[]="jest"
public-hoist-pattern[]="tsconfig-seek"
# end managed by skuba
1 change: 1 addition & 0 deletions packages/skuba-dive/.prettierignore
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,5 @@
gantry*.yaml
gantry*.yml
pnpm-lock.yaml
coverage
# end managed by skuba
Loading
Loading