Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zephyrus Duo - Screenpad Toogle only mode #1450

Closed
phu54321 opened this issue Oct 12, 2023 · 2 comments
Closed

Zephyrus Duo - Screenpad Toogle only mode #1450

phu54321 opened this issue Oct 12, 2023 · 2 comments
Labels
question Further information is requested

Comments

@phu54321
Copy link

phu54321 commented Oct 12, 2023

Is your feature request related to a problem? Please describe.

Screenpad currently alternates between "Brightness 100%", "Hidden (brightness 0%)", "Off". I want an option to alternate only between "On" and "Off".

Describe the solution you'd like

I usually set second screen brightness using ScreenXpert button. I don't want g-helper to change the screenpad brightness. I only want to toggle it on/off (for battery)

image

Describe alternatives you've considered

Add ToggleScreenpad function to InputDispatcher.cs

        public static void ToggleScreenpad(bool enable)
        {
            string toast;
            if (enable) {
                toast = "On";
                Program.acpi.DeviceSet(AsusACPI.ScreenPadToggle, 1, "ScreenpadOn");
            }
            else {
                toast = "Off"
                Program.acpi.DeviceSet(AsusACPI.ScreenPadToggle, 0, "ScreenpadOff");
            }

            Program.toast.RunToast($"Screen Pad {toast}", delta > 0 ? ToastIcon.BrightnessUp : ToastIcon.BrightnessDown);
        }

Additional context

Testing available.
If you accept PRs, I'm willing to create one.

@seerge
Copy link
Owner

seerge commented Oct 12, 2023

@phu54321 hello,

So you want to remove one of the steps from the list ? Thing is that current scenario I have recreated according to what another Duo user was asking #1215 :) and that will break it

I can add an optional config param, that will allow that. As this is quite specific usecase that you want.

Will that work ?

@seerge seerge added the question Further information is requested label Oct 12, 2023
@seerge
Copy link
Owner

seerge commented Oct 20, 2023

@phu54321 this build should do the thing. Apparently I did this accidentally by trying to sort other request

GHelper.zip

@seerge seerge closed this as completed Oct 20, 2023
seerge added a commit that referenced this issue Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants