Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay in Screen Pad On/Off/Disconnect action #2296

Closed
2 tasks done
rollercoaster opened this issue Mar 26, 2024 · 11 comments
Closed
2 tasks done

Delay in Screen Pad On/Off/Disconnect action #2296

rollercoaster opened this issue Mar 26, 2024 · 11 comments
Labels

Comments

@rollercoaster
Copy link
Contributor

Rules

  • I made myself familiar with the Readme, FAQ and Troubleshooting.
  • I understand that, if insufficient information will be provided, my issue will be closed without an answer.

Is your feature request related to a problem? Please describe

Currently it is very hard to go directly from, say, On to Disconnected or to simply cycle back to current value if you accidentally press the screen pad mode change button. It is quote jarring when the button is pressed and even before you can read the toast notification, the screen flicker.

Describe the solution you'd like

Can we please have a delay (just like the charge delay) that delays the action once the screen pad mode change button / shortcut is pressed? If we cycle back to the current stage then no action should happen.

Describe alternatives you've considered

No response

Device and Model

ASUS Duo 15 SE

Additional information.

No response

@seerge
Copy link
Owner

seerge commented Mar 26, 2024

@rollercoaster hello, it's very hard to understand what are you asking, but you already can set screenpad brighter or dimmer (up to completely turning it off) with a hotkeys as explained in readme

Fn + Shift + F7 / F8 - Screenpad brightness Down / Up

So I don't think that anything else next to that needs to be added.

If you want a delay between settings - just press buttons less frequent.

@rollercoaster
Copy link
Contributor Author

Thank you for your prompt reply. Yes, I am aware of the brightness shortcuts and they are great.

But I am talking about the this button:
image

The actions are:
Screenpad ON, Screenpad Hidden, Screenpad Disabled

Each time the button is pressed the mode changes. It would be really great if the action for this button is delayed (as is the default behaviour in the Asus's terrible apps)

@seerge
Copy link
Owner

seerge commented Mar 26, 2024

@rollercoaster what is the purpose of the delay ?

@rollercoaster
Copy link
Contributor Author

Reduces the windows rearrangement and resolution/positing/refresh-rate change of the screen(s)

The most common use case is to go from Screenpad On to Screenpad Disabled but we cant do that in the current functionality as it will rapidly go from On to Off to Disabled

Another use case is accidental press, when the screen is off. It would go from Disabled to On to Off to Disabled.

A delay allows the user to settle of a final state of the action and the action then happens only once.

@seerge
Copy link
Owner

seerge commented Mar 26, 2024

@rollercoaster I don't think that adding artificial delay to a very simple action is a good idea. It will just give impression that application is laggy.

You can also do Shift + Screenpad to just toggle Screenpad on or off.

@rollercoaster
Copy link
Contributor Author

The way I have see it working is:

  1. You press the button
  2. You see the notification on the screen to indicate the change
  3. After a second the action occurs
  4. if you press again before the action, it cancels the pending action and goes to step 2

Shift + Screenpad does indeed work to turn Off but does not turn On the 2nd screen

@seerge
Copy link
Owner

seerge commented Mar 26, 2024

@rollercoaster check if this build does toggle screenpad on Shift + Sreenpad hotkey
GHelper.zip

seerge added a commit that referenced this issue Mar 26, 2024
@rollercoaster
Copy link
Contributor Author

rollercoaster commented Mar 26, 2024

Yes that fixes Shift + Screenpad toggle. Thanks!

I would still suggest adding the delay.

@seerge
Copy link
Owner

seerge commented Mar 26, 2024

@rollercoaster delay is much more difficult to do, and it can be very confusing for people who didn't get used to it.

@rollercoaster
Copy link
Contributor Author

ok, thanks for everything! Love the app.

@rollercoaster
Copy link
Contributor Author

FYI, not meaning to push, but anyone using this app is coming from Asus software and that has the delay built in so it shouldn't really confuse anyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants