arrow keys to modify fan curve points

[moms-spaghetti]

Rules

• I made myself familiar with the Readme, FAQ and Troubleshooting.
• I understand that, if insufficient information will be provided, my issue will be closed without an answer.

Is your feature request related to a problem? Please describe

granular adjustment of fan curves value can be difficult when using a pointing device as small movements when releasing mouse buttons / trackpad are still recorded as inputs

Describe the solution you'd like

clicking on a fan curve point focuses it and allows arrow keys to be used for granular adjustment based on lowest unit graph increments

Describe alternatives you've considered

Double click a fan curve box to increase it's size so finer adjustments with a pointing device are easier

Device and Model

Asus Strix G16 G614JZ

Additional information.

No response

[seerge]

@moms-spaghetti hello,

I can try to add something like that but

• BIOS never follows fan curve precisely, and often has deviations. You should understand it only as approximate guidance. So it doesn't make much sense in pixel-peeping here
• Current UI logic is to immediately apply custom fan curve as soon as you release left mouse button (if "apply" is already checked). It won't work like that for keyboard obviously

[moms-spaghetti]

Thanks @seerge I didn't know the bios mapping of fan curves wasn't precise - good to know.
Will the implementation for using keys to adjust points require an apply button? Maybe some sort of debounce before applying changes for each keystroke will help?

[seerge]

@moms-spaghetti ok, I have checked deeper, and it's actually harder to do than I thought :) whole fan-editor is actually just a "modified" windows charts component. And it's a lot of work to allow selecting dots manually, handing their movements from keys, etc.

So on this stage I'm not a big fan of that.

In addition, as I have initially mentioned fan curve (set in % points under the hood), is quite approximate guidance for BIOS, not precise. So couple of pixels up or down in reality won't make any difference.

What UI scaling do you use ? cause on mine 150% or 200% it's really easy to drag dots quite precisely.

Did you know you can drag whole curve by holding SHIFT ?

[moms-spaghetti]

@seerge Ah ok does sound like it'll be more pain than it's worth to implement for little gain so can understand you not wanting to go down that route.

I am using 1920x1200 100% scale screen size 16", The windows are quite small, even with a mouse it's 'fiddly' to use but not impossible. Maybe an alternative could be a pop out for the graphs which can be resized if it's not a rabbit hole to implement?

[seerge]

@moms-spaghetti I can add maximize button to Fans+Power, so it will go full-screen
GHelper.zip

[seerge]

@moms-spaghetti does it solve your problem ?

[moms-spaghetti]

@seerge ah! that's excellent thank you! was the implementation of this easier?

edit: I'd say this one is completed ✅

[seerge]

@moms-spaghetti yes, that’s easier, you can check actual charges in a linked commit :)