-
-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for Vivobook M1405 #2445
Comments
@thinhkhuat hello, you are mixing multiple things together. For Dimming / Visual modesYour model indeed needs to be added to config. Please check this build it should enable features on your model. I think for Vivobooks you don't need GameVisual folder even, as FN-LockMost Vivobooks / Zenbooks have own hardware FN-Lock. It's toggled via Keep in mind, that if you have Asus Services running - they will interfere (and also toggle fn-lock). So you need to stop them via HotkeysMost probably your device simply doesn't support FN+C or FN+V, as they produce no keycode. You can check app log in realtime after pressing them, if there are no WMI EVENT or KEY CODE appearing in the log, those hotkeys are not supported on your device and therefore can't be processed. |
Hi, thank you very much for your swift reply. I do apologise for the mix up, bcoz English is not my 1st language so probably I couldn't make myself clear. Let me try to explain things to you again:
It has F1 for Mute, F2 for Volume down, F3 for V-Up, F4 for Brightness down, F5 for B-up, F6 for touchpad On/Off, F7 is blank, F8 is for screen-mirror options, F9 for Mute the Mic, F10 is blank, F11 for screenshots, F12 is the MyAsus key. All of these keys will work when Fn-lock status reported OFF by GHelper (which is ON in reality). Keys that would work when binding by the extra menu will be the MyAsus key (F12) and by choosing the M4/ROG option. I can set it up to open GHelper, toggle different modes, screen on/off, lock screen, toggle fn-lock but that will be it. Thank you so much for the time and effort you've spent to create this little wonderful tool. I really appreciate your work. |
When FN Lock is turned OFF - you need to press FN + F-key in order to get special function If it's not the case, it could be that your device has everything upside-down comparing to other Vivobooks. Keep in mind, that FN-Lock in your case is handled by hardware, G-Helper can only send a command to toggle it.
Then there is nothing I can do here. |
@thinhkhuat any updates on the matter ? |
Hi, sorry i was overwhelmed with work, there was an emergency matter so I had to focus on that. Just when I was done, I got your message :) When ON in reality, it works when pressing F1 for mute, F2 to decrease volume, and so on. So yes, it might have the Fn thingy up side down as you reckoned. I really would like to bind some hotkeys to do flicker-free dimming, as the brightness control that Asus's Fn system does will engage the default Windows's method to +/- brightness, not the flicker-free method implemented by you or MyAsus. With that default method by Windows, anything below 60% will not be flicker-free, as you have known. Thank you, and apologise for the late reply again. |
@thinhkhuat ok, Try this build, it should invert fn-lock for your model As for Flicker-free dimming you can hold CTRL + FN + F4/F5 it should do the thing. |
Hi, now it does not enable Fn-lock somehow. The notifications I get will be OFF and cannot get it to turn ON by any mean. I re upload the log.txt for your references. |
@thinhkhuat try this build instead for fn-lock
Problem is that FN+F4/F5 send brightness commands to windows directly on hardware level, so I can't really stop that anyhow from the app |
Hi, Fn-lock now works as it should :) Thank you! If you have more time, you could update it with the hotkeys fix in the future, if not - due to the hardware problem then it will still be fine though. You've been really nice and helpful person to all of us by now. Definitely will buy you a cup of coffee to express my gratitude towards your effort. I really appreciate it. |
@thinhkhuat my point is that I can't "unbind" fn+F4/F5 from their default behavior. What hotkeys do you suggest for dimming ? |
Yes I understand your concern. I'm not asking you to bind Fn F4/5 to change brightness - that will interfere with windows commands. |
@thinhkhuat i can’t use fn+(any) combos as in your case they work on hardware level. Let’s keep like this for now. I’m closing this as resolved as oled / fnlock is working correctly now |
Rules
Is your feature request related to a problem? Please describe
Hi, my Vivobook M1405YA with AMD Ryzen 5 7530 and an OLED screen at 2880x1800 does not show the OLED features with the latest build of G-Helper. I tried downloading the source code and modified the app.config file with a || ContainsModel(M1405) to the isOLED() function and successfully got the OLED features showed up, including the flicker-free dimming (with the .icc profile put in the GameVisual folder manually).
However, it seems the function-lock feature is not working correctly. I tried the script you posted in other threads that involving WMI method sth and it returned the 65636 - true values for both the ON and OFF states (triggered manually). Due to this problem, the hotkeys also doesn't work, not allowing any kind of hotkeys like fn+C, fn+V or fn+F4 .....
I tried disabled the fn lock in MyAsus, Bios but no luck. The fn lock status in GHelper always reports the other way comparing to the Asus fn lock status.
Describe the solution you'd like
For OLED features, it seems simple enough to add support for this Vivobook model. Please add support for it when you have time, I really appreciate your support and the quality of GHelper. It's an essential tool for me when using 2 Asus laptops now.
for the fn-lock problem, I understand by reading other threads that support for fn lock will not work because GHelper couldn't get the status and sync its feature with Asus's implementation.
However, it seems you could somehow reset the fn lock status at launch of GHelper and as I understand from the other threads, it worked for others. But in my Vivobook M1405, it does not. I tried reading and modifying the InputDispatcher to get a temp fix but couldn't do so, probably too complicated for me to do so :(
Thank you very much!
Describe alternatives you've considered
No response
Device and Model
Asus Vivobook M1405YA
Additional information.
No response
The text was updated successfully, but these errors were encountered: