-
-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Static Slash Lighting Mode #2448
Comments
@reckthaworlde as I was telling here few times, I don't have access to the device anymore, therefore it's extremely difficult to play a piano without actual piano. I have added some test payload, that COULD BE static white, can you check if it makes a difference ? It's a new option in Slash Modes dropdown And post a log from the app |
Tried this, doesn't seem to change from the previously selected option.
|
@AlecMulder ok, try this one instead |
@seerge no change.
|
@AlecMulder this is one more attempt. If this one still doesn't make any difference, i'm afraid that's not possible to do w/o having access to the actual device |
@seerge that works! Thank you so much! Brightness settings don't work if you feel so inclined.
|
@AlecMulder ok, i'm not sure where the brightness is set, Can you check if this build is able to change it ? |
@seerge No Joy. Wish I could help you more but the rest of the app is outside my wheelhouse. Is there a simple way to send these commands to the hid device? (if that's even what's going on) Google wasn't much help. I know serial devices.
|
@AlecMulder try this build, apparently above link keeps sending same 0xFF as brightness no matter what ... |
@AlecMulder and since you are responding faster than issue starter, can you check if it also fixes this issue #2447 (i.e. unchecking "disable on battery" doesn't turn on lighting immediately) |
@seerge no change unfortunately. Here I set to bounce and went thought brightness levels, works as expected. Then went to static and through the options, only change is it turns off when set to off.
|
@AlecMulder, brightness for hardcoded modes is set in a different way, so it it's not applicable I'm trying to find what byte in this payload is brightness
Try this build |
@seerge figured it was something along those lines, just unfortunate I can't open a serial port and send those bytes to test quickly. Worth me figuring out the development environment for this? Latest build didn't work. Not sure if this is still useful, maybe at minimum to ensure I'm using the correct build.
|
@seerge or perhaps dumb idea, make a bunch of options in that dropdown I can go through? |
@AlecMulder ok, may be it's not even possible to set a general brightness I can just set each led to be dimmer |
@seerge works perfectly. Thanks! |
@AlecMulder great, thanks for checking. Closing as resolved then. Since you respond fast. If you want - you can try to record payloads from AC to disable slash lighting for sleep / lid closed states in this issue #2381 |
Happy to help! I'll check that in a few hours. |
Rules
Is your feature request related to a problem? Please describe
No.
Describe the solution you'd like
It was mentioned to me by many people that the Slash Lighting is striking, but also distracting. I think a simple animation that just glows statically would be much appreciated by many people who enjoy the back lighting but don't want to draw too much attention in public.
Describe alternatives you've considered
The "bit stream" animation is about as close as possible to what I mentioned, but it still very animated and could be distracting.
Device and Model
Zephyrus g16 gu605mz
Additional information.
No response
The text was updated successfully, but these errors were encountered: