Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable on lid close option makes no difference #3054

Closed
2 tasks done
amdk1 opened this issue Sep 2, 2024 · 11 comments
Closed
2 tasks done

Disable on lid close option makes no difference #3054

amdk1 opened this issue Sep 2, 2024 · 11 comments
Labels
question Further information is requested

Comments

@amdk1
Copy link

amdk1 commented Sep 2, 2024

Rules

  • I made myself familiar with the Readme, FAQ and Troubleshooting.
  • I understand that, if insufficient information or no app logs will be provided, my issue will be closed without an answer.

What's wrong?

Hi there,
I'm on version 0.187.0 of G-Helper. My strip lighting turns off when I close the lid even though the "Disable on lid close" option is unchecked. Checking it makes no difference to the behavior.

How to reproduce the bug?

  1. uncheck "Disable on lid close"
  2. close lid - slash lighting turns off

Logs

log.txt

Device and Model

Asus Zephyrus G14 GA403UV

Additional information.

I tried reinstalling armory crate. The slash lighting was working as expected with AC's settings (only when using AC lighting presets), however, once I uninstalled AC and switched back to g-helper, the slash lighting went back to turning off on lid close.

Armoury Crate

Uninstalled

Asus Services

None

Version

0.187.0

OS

Windows 11 23H2

@seerge
Copy link
Owner

seerge commented Sep 2, 2024

@amdk1 hello, i see that you use battery level mode. This one is custom and app manually sets slash lighting pattern based on current battery level every minute.

What happens if you would set any other mode (that is baked into firmware) ?

@amdk1
Copy link
Author

amdk1 commented Sep 2, 2024

I just tried some of the built-in armory crate modes, the lighting still turns off on lid close.

@amdk1 amdk1 closed this as completed Sep 2, 2024
@amdk1 amdk1 reopened this Sep 2, 2024
@seerge
Copy link
Owner

seerge commented Sep 2, 2024

@amdk1 ok, can you check if behavior is same when laptop is plugged and and on battery ?

@amdk1
Copy link
Author

amdk1 commented Sep 2, 2024

Just tried this, it's working as expected when plugged in on all lighting modes.

@seerge
Copy link
Owner

seerge commented Sep 2, 2024

@amdk1 ok, i think it's a firmware-level behavior of a slash lighting to preserve battery actually.

Do you have Disable on battery checked in the app by any chance ? (and if so ... lighting should be turned off completely when you are on battery, not only when you close the lid)

@amdk1
Copy link
Author

amdk1 commented Sep 2, 2024

Disable on battery is unchecked, the lighting turns off completely when it's checked on battery.

I just played around a bit with the lighting with the charger plugged in, the slash lighting behavior is inconsistent even on lid close while plugged in. It seems to be behaving like this depending on what state the laptop is plugged in:

scenario one:

  1. Laptop is already plugged in and the lid is open
  2. Disable on lid close is unchecked
  3. Lid is now closed
  4. The selected lighting mode does not play, but the slash lighting starts the breathing animation as it's charging

Scenario two:

  1. The laptop is not plugged in and the lid is closed (same g-helper settings as scenario one)
  2. The laptop is then plugged in while the lid is closed
  3. The selected lighting mode animation plays 3 times before reverting to the breathing animation in scenario one

Edit - I'd like to add that the lighting had the same behavior in my earlier comment when I said that it worked as expected while plugged in, I hadn't noticed it at that point.

@seerge
Copy link
Owner

seerge commented Sep 2, 2024

@amdk1 can you check if this build makes any difference ?

GHelper.zip

@amdk1
Copy link
Author

amdk1 commented Sep 3, 2024

It's working with the lid closed on all armory crate lighting modes now.

"Static" and "battery level" modes only work while the lid is open. Upon closing the lid with either of these two modes, the lighting reverts to the last selected armory crate lighting mode.

Battery level also seems to not work anymore as all 5 zones are lit up while I have a charge level of 77.4%

@seerge
Copy link
Owner

seerge commented Sep 3, 2024

@amdk1 ok,

I think in case of Static and Battery level modes - it can't be changed, as they are "software modes" (i.e. app manually sets pattern) and apparently firmware is programmed to shut it down on lid close

As for the rest - does it work in all conditions (ie. plugged in / unplugged) ? Also does Disable on battery action work correctly still ?

@seerge seerge added the question Further information is requested label Sep 3, 2024
@amdk1
Copy link
Author

amdk1 commented Sep 3, 2024

Apologies for the delay, I didn't have my charger with me. All the non-software/AC modes are working both plugged in / unplugged. Disable on battery is also working as expected :)

@seerge
Copy link
Owner

seerge commented Sep 3, 2024

@amdk1 great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants