Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flash touchscreen status when using the touchsceen toggle from one of the ASUS hotkeys #3143

Closed
2 tasks done
switchblade34 opened this issue Sep 20, 2024 · 16 comments
Closed
2 tasks done
Labels
question Further information is requested

Comments

@switchblade34
Copy link

Rules

  • I made myself familiar with the Readme, FAQ and Troubleshooting.
  • I understand that, if insufficient information will be provided, my issue will be closed without an answer.

Is your feature request related to a problem? Please describe

Not related to any problem

Describe the solution you'd like

On my FlowX16 I can set the M3 button to toggle the touchscreen. I was hoping is there way to add a pop-up flash similar to one that appears when changing the keyboard lighting brightness to tell the user if the touchscreen was turned on or off.

Describe alternatives you've considered

No response

Device and Model

Asus Flow X16 GV601VI

Additional information.

No response

@seerge
Copy link
Owner

seerge commented Sep 20, 2024

@switchblade34 hello,

I'm not sure if I'm following you.

You can already toggle touchscreen via hotkeys (set under Extra). And if touchscreen toggle was successful - it already show a toast notification saying if it's ON or OFF

Please keep in mind, due to the way toggle works (it disables it via device manager) - it requires admin rights. So you need to run app as admin.

if (touchscreenStatus is not null)

@seerge seerge added the question Further information is requested label Sep 21, 2024
@seerge
Copy link
Owner

seerge commented Sep 22, 2024

@switchblade34 does running app as admin solve your problem ?

@switchblade34
Copy link
Author

Yep, it is running as admin. When I did the toggle the first time, it asked for admin rights which I gave. It turns the touchscreen on and off. It's just the toast that's not showing up.

@seerge
Copy link
Owner

seerge commented Sep 22, 2024

@switchblade34 can you upload log from the app from %appdata%\GHelper here?

@switchblade34
Copy link
Author

log.txt

@seerge
Copy link
Owner

seerge commented Sep 22, 2024

@switchblade34 ok, it looks like a toggling is indeed happening in your case. So toast notification should appear as well. Do other notifications appear correctly ? (like backlight level)

At what moment do you press the button to toggle? Cause if you run a full-screen game then, it may not allow any notifications then.

Can you try this build and upload log from it ?

GHelper.zip

@switchblade34
Copy link
Author

Yes, the toggle happens. It's just the toast that's not displaying. I am not in any app when switching. Doesn't show up even when I am on my desktop. Other toasts like backlight, brightness, aura modes, performance modes; all those toasts work fine.

Tried the attached build. Still does not show the toast. But it still does toggle the touchscreen. Logs attached.

log.txt

@seerge
Copy link
Owner

seerge commented Sep 22, 2024

@switchblade34 hmm, it's strange, cause toast in this case is same as in all others.

Furthermore, i tried it on my laptop and toast appears (keep in mind it appears with like a 1-2 seconds delay, cause whole command to toggle touchpad takes time)

Can you try this build and post a log ?
GHelper.zip

@switchblade34
Copy link
Author

Still no toast. I waited for 10sec between each toggle to give time for the toast to appear but it did not.
Log attached:
log.txt

@seerge
Copy link
Owner

seerge commented Sep 22, 2024

@switchblade34 ok. Weird :)

Can you check this build ? I have just added a dummy touchpad toast even before actual toggle happens to see if it appears in your case or not
GHelper.zip

@switchblade34
Copy link
Author

This build works.

Behaviour:

Touchscreen is set to on at the start.

  1. Press M3
  2. Toast appears with touchpad icon and says touchscreen on
  3. Moments later it updated to touchsceen off with the same touchpad icon
  4. I swipe around on the screen and the touchscreen is indeed off.

Works the same when turning it back on as well. It works now.

@seerge
Copy link
Owner

seerge commented Sep 23, 2024

@switchblade34 ok, glad to hear. Can you check if this build still works ?

It won't show a dummy (and incorrect) toast first, but should show only correct one.

The only difference it would show it before actually running actual toggle command (to tackle delay)

GHelper.zip

seerge added a commit that referenced this issue Sep 23, 2024
@seerge
Copy link
Owner

seerge commented Sep 24, 2024

@switchblade34 did you had a chance to try last build ?

@switchblade34
Copy link
Author

switchblade34 commented Sep 24, 2024

Sorry, had a busy day. Just tried the latest build and it works fully as expected including the toast.
The only nitpick issue I would say is that the icon in the update toast is that of the touchpad. The functionality is working just an UI issue remaining I would say.

@seerge
Copy link
Owner

seerge commented Sep 24, 2024

@switchblade34 well, i don't have an icon for a screenpad :) and since it's such a minor thing I suggest to keep it as is.

Closing as resolved then

@seerge seerge closed this as completed Sep 24, 2024
@switchblade34
Copy link
Author

Yea sure no worries. A quick google search got me this icon that you could use if you like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants