Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Holding shift while Changing volume Changes keyboard Backlight and Holding Ctrl Does nothing. #960

Closed
soundwaves7 opened this issue Aug 1, 2023 · 11 comments
Labels
question Further information is requested

Comments

@soundwaves7
Copy link

Describe the bug
holding shift key while changing volume using volume buttons on keyboard changes the keyboard backlight and stops volume from being adjusted, same thing when holding control but nothing changes

Clear scenario to Reproduce
Hold Shift and press Volume keys (+/-)
Hold Ctrl and Press Volume Keys (+/-)

Expected behavior
Volume to be adjusted in both cases and nothing else.

App Logs
log.txt

Screenshots or screencasts
image

Desktop (please complete the following information):

  • OS: Windows 11
  • Laptop model Asus TUF FX706HE

Asus software
None

Additional context

@seerge
Copy link
Owner

seerge commented Aug 1, 2023

@soundwaves7 hello,

This is intentional addition (contribution by one of the users) in https://github.com/seerge/g-helper/releases/tag/v0.100

CTR+M1/M2 change screen brightness (if it's supported)
SHIFT+M1/M2 change backlight brightness

Why do you want to disable this feature?

@seerge seerge added the question Further information is requested label Aug 1, 2023
@seerge
Copy link
Owner

seerge commented Aug 1, 2023

@soundwaves7 this build should also allow to change screen brightness correctly on TUF models from Ctrl+M1/M2
GHelper.zip

@thepriyamkalra
Copy link

Hi @seerge, On my TUF F15, Shift+M1/M2 (Shirt+FnF2/F3) changes the keyboard backlight just fine, but brightness doesn't work quite right with Ctrl+M1/M2.

On v0.103, it was working fine, just that the buttons were opposite (M1/Fn+F2 was brightness+ and M2/Fn+F3 was brightness-).
(this is not the case for Shift+M hotkeys)

And on the linked build, M1 is still increasing the brightness, but it seems to go to 90% then goes back down to 80% and repeat, same deal with M2 where it is able to decrease brightness to 10% then goes back up to 20% and repeat

Here's the log of all the button spamming but I dont know if it'll be of much help
log.txt

@seerge
Copy link
Owner

seerge commented Aug 1, 2023

@thepriyamkalra as far as i remember you had brightness controls swapped also for fn-lock case, correct?

@thepriyamkalra
Copy link

@seerge Yup, and now the fn-lock brightness controls are also showing the same behavior.

@seerge
Copy link
Owner

seerge commented Aug 1, 2023

@thepriyamkalra

This should be fine (i hope)

GHelper.zip

@soundwaves7
Copy link
Author

@soundwaves7 this build should also allow to change screen brightness correctly on TUF models from Ctrl+M1/M2 GHelper.zip

Is there a way to disable the ctrl and shift binding, it conflicts with a binding i have on my mouse
Most of the time i change volume using my mouse while working with figma, photoshop etc.. or in a game and while holding the shift or ctrl keys so if possible can these bindings be disabled fo g helper?

@seerge
Copy link
Owner

seerge commented Aug 1, 2023

GHelper.zip

@soundwaves7 add

"skip_hotkeys":1, to config.json and and restart start app after that :)

seerge added a commit that referenced this issue Aug 1, 2023
@seerge seerge closed this as completed Aug 1, 2023
@thepriyamkalra
Copy link

thepriyamkalra commented Aug 2, 2023

@thepriyamkalra

This should be fine (i hope)

GHelper.zip

Okay so now the M1/M2 keys work consistently, but they are still swapped, so M1 is brightness+ and M2 is brightness-
and the function keys have just stopped doing anything with FnLock on.

PS: Let me know if I should move this to separate issue

@seerge
Copy link
Owner

seerge commented Aug 2, 2023

@thepriyamkalra yes, please do with a log :) cause it mixes up all things ...

@seerge
Copy link
Owner

seerge commented Aug 2, 2023

@thepriyamkalra just to be safe : uploading here latest build (in case i messed things up by trying to solve other issue here)

GHelper.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants