-
-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Holding shift while Changing volume Changes keyboard Backlight and Holding Ctrl Does nothing. #960
Comments
@soundwaves7 hello, This is intentional addition (contribution by one of the users) in https://github.com/seerge/g-helper/releases/tag/v0.100 CTR+M1/M2 change screen brightness (if it's supported) Why do you want to disable this feature? |
@soundwaves7 this build should also allow to change screen brightness correctly on TUF models from Ctrl+M1/M2 |
Hi @seerge, On my TUF F15, Shift+M1/M2 (Shirt+FnF2/F3) changes the keyboard backlight just fine, but brightness doesn't work quite right with Ctrl+M1/M2. On v0.103, it was working fine, just that the buttons were opposite (M1/Fn+F2 was brightness+ and M2/Fn+F3 was brightness-). And on the linked build, M1 is still increasing the brightness, but it seems to go to 90% then goes back down to 80% and repeat, same deal with M2 where it is able to decrease brightness to 10% then goes back up to 20% and repeat Here's the log of all the button spamming but I dont know if it'll be of much help |
@thepriyamkalra as far as i remember you had brightness controls swapped also for fn-lock case, correct? |
@seerge Yup, and now the fn-lock brightness controls are also showing the same behavior. |
This should be fine (i hope) |
Is there a way to disable the ctrl and shift binding, it conflicts with a binding i have on my mouse |
@soundwaves7 add
|
Okay so now the M1/M2 keys work consistently, but they are still swapped, so M1 is brightness+ and M2 is brightness- PS: Let me know if I should move this to separate issue |
@thepriyamkalra yes, please do with a log :) cause it mixes up all things ... |
@thepriyamkalra just to be safe : uploading here latest build (in case i messed things up by trying to solve other issue here) |
Describe the bug
holding shift key while changing volume using volume buttons on keyboard changes the keyboard backlight and stops volume from being adjusted, same thing when holding control but nothing changes
Clear scenario to Reproduce
Hold Shift and press Volume keys (+/-)
Hold Ctrl and Press Volume Keys (+/-)
Expected behavior
Volume to be adjusted in both cases and nothing else.
App Logs
log.txt
Screenshots or screencasts
Desktop (please complete the following information):
Asus software
None
Additional context
The text was updated successfully, but these errors were encountered: