-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly disable OOBE mode #3169
Conversation
@dantmnf hello, thanks Can you clarify a bit what this endpoint does ? cause based on other user's test it seem to be backlight brightness toggle (i might be wrong tho). What does OOBE stands for ? |
I think this should be a "feature" to indicate the system is starting by turning keyboard backlight on and off. The term OOBE (out-of-box experience) is taken from Linux The two affected models AFAIK are on shining new platform (AMD Strix Point / Intel Lunar Lake), I'm not sure if Asus repurposed the endpoint in this generation. |
@dantmnf ok, then it could be that I have misunderstood sense of this in a first place. So to summarize Setting |
I haven't checked if this will make keyboard blink again - obviously not a feature wanted for daily use, but it do have value |
@dantmnf but can you set it to 0 and check what effect it has ? Does keyboard start blinking ? |
Ok I will check it when the device comes back to me - maybe a few days later |
It has no effect. The keyboard won't start blinking again until a full shutdown and restart. |
@dantmnf ok, great. Then I have misinterpreted sense of this endpoint based on on feedback of other users. Since OOBE resets on reboot, i assume it will also reset on hibernate / wakeup from it. So it makes sense to run it every time device changes power mode. I have added OOBE command to TUF Keyboard Power method instead (responsible for backlight zones in different states and running every time power is changed) Line 833 in 740a34f
Can you check if this build works properly ? |
You're right. I didn't think about the hibernate case.
It works well. |
@dantmnf ok! then i assume it's fine as is now? Thanks for spotting and clarifying! |
I have a new Vivobook S16 and have this issue when turning my laptop on. Do I need to trigger something in GHelper to stop the rainbow puke or is this just supposed to work out of the box with GHelper? Side note - thanks for adding my laptop to OLED list. |
@memnon8711 you don't need to do anything, as far as you use latest release - it will set this command as soon as app starts. You can verify it by checking if record mentioning |
I do see the line "VIVO OOBE = 1 : OK" in the log file. I just notice the rainbow RGB comes one when I turn on the computer and I have to cycle through the brightness to turn it off. Small nit. |
@memnon8711 can you check if this build behaves differently ? |
That worked. The rainbow RGB was displaying when it booted up, but once Windows and GHelper loaded, it turned off the lighting and went back to the state I had it in previously. Thanks for the quick response. |
@memnon8711 ok, great . I just swapped OOBE command and initial backlight setting that app sets |
Originated from torvalds/linux@d6de45e and also tested on Zenbook S 14 (UX5406SA).
Without setting
0x0005002F
to1
, the keyboard backlight will keep breathing and uncontrollable.Not sure how it will behave on other models though.