Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eco mode switching instability fix #855

Closed
wants to merge 3 commits into from
Closed

Conversation

joe-700
Copy link

@joe-700 joe-700 commented Jul 22, 2023

Fix for system instability when switching to eco mode, this prevents the need to force GPU drivers to reset.

The current BIOS for new G14s does not boot correctly into eco GPU mode, this results in loss of Nvidia display modes i.e. advanced optimus, and loss of brightness controls. Currently a GPU driver restart is used to correct this state but this operation can either: hang, result in loss of brightness controls, and will often require a couple of resets to fully rectify. I have noticed system instability after doing this including one blue screen crash.

This fix will ensure that the GPU mode switch is set to normal before system shutdown and hibernation in order to guarantee booting into a safe state.

Current user selected GPU modes are honored by setting flags in the newly created xml file and restoring the GPU state after booting correctly into normal mode.

…the need to force GPU drivers to reset.

The current BIOS for new G14s does not boot correctly into eco GPU mode, this results in loss of Nvidia display modes i.e. advanced optimus, and loss of brightness controls. Currently a GPU driver restart is used to correct this state but this operation can either: hang, result in loss of brightness controls, and will often require a couple of resets to fully rectify. I have noticed system instabiliy after doing this including one blue screen crash.

This fix will ensure that the GPU mode switch is set to normal before system shutdown and hybernation in order to guarantee booting into a safe state.

Current user selected GPU modes are honered by setting flags in the newly created xml file and restoring the GPU state afer booting correctly into normal mode.
@joe-700 joe-700 closed this Jul 23, 2023
@joe-700
Copy link
Author

joe-700 commented Jul 23, 2023

I have a modified version that uses the app config to track the eco mode shutdown

@joe-700 joe-700 reopened this Jul 23, 2023
@joe-700
Copy link
Author

joe-700 commented Jul 23, 2023

As above only using the app config to track eco mode shutdown

@seerge
Copy link
Owner

seerge commented Jul 23, 2023

@joe-700 hello, i can't accept your PR as it will be forcing standard mode for all devices.

But I have already implemented pretty much same thing as you wanted (by looking at what you propose)
20b9981

You need to set "gpu_fix" : 1, in config.json.

And it will force standard mode on shutdown / and session ending events. And restore last GPU mode on startup (that implementation was already in the app)

@seerge seerge closed this Jul 23, 2023
@seerge
Copy link
Owner

seerge commented Jul 23, 2023

@joe-700 check this build , it should do the same :
GHelper.zip

Does it work for you?

@joe-700
Copy link
Author

joe-700 commented Jul 23, 2023

That build works a treat.

I went back and tried the current version, via the download link from the main page. That one does not work, are you intending to roll this into the main branch?

@seerge
Copy link
Owner

seerge commented Jul 23, 2023

@joe-700 I just pushed it live as 0.101
https://github.com/seerge/g-helper/releases/tag/v0.101

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants