Skip to content

Commit

Permalink
oneVideo Bid Adapter: remove adapter adId because of conflict with pb…
Browse files Browse the repository at this point in the history
…js core (prebid#6382)

* updated object,str,num validations using pbjs utils

* validation if statements for content object

* validation if statements for content object

* updated contetn object validations using utils

* refractoring clean if statement

* fixing typos

* added todos

* added category string & data object validations

* fixed esling ENDPOINT issue

* updated content obj unit tests

* fixed cat & data validation

* fixed producer as object

* revert .includes() to .indexof() for IE

* reduced content obj params accoriding to ad-server support

* fixed typeOf typo

* fixed episode to Number

* gitignore

* restore gitignore

* removed unsupported params from md file

* reverted package & pagkage-lock

* fixed incorrect episdoe from str to num

* removed bid.adid setting from L97

* removed bid.adId setting

* updated adId test

* updated version to 3.0.6
  • Loading branch information
adam-browning authored and seergiioo6 committed Mar 23, 2021
1 parent 8432c42 commit 11017ae
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
3 changes: 1 addition & 2 deletions modules/oneVideoBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import {registerBidder} from '../src/adapters/bidderFactory.js';
const BIDDER_CODE = 'oneVideo';
export const spec = {
code: 'oneVideo',
VERSION: '3.0.5',
VERSION: '3.0.6',
ENDPOINT: 'https://ads.adaptv.advertising.com/rtb/openrtb?ext_id=',
E2ETESTENDPOINT: 'https://ads-wc.v.ssp.yahoo.com/rtb/openrtb?ext_id=',
SYNC_ENDPOINT1: 'https://pixel.advertising.com/ups/57304/sync?gdpr=&gdpr_consent=&_origin=0&redir=true',
Expand Down Expand Up @@ -94,7 +94,6 @@ export const spec = {
requestId: bidRequest.bidId,
bidderCode: spec.code,
cpm: bid.price,
adId: bid.adid,
creativeId: bid.crid,
width: size.width,
height: size.height,
Expand Down
3 changes: 1 addition & 2 deletions test/spec/modules/oneVideoBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ describe('OneVideoBidAdapter', function () {
const placement = bidRequest.params.video.placement;
const rewarded = bidRequest.params.video.rewarded;
const inventoryid = bidRequest.params.video.inventoryid;
const VERSION = '3.0.5';
const VERSION = '3.0.6';
expect(data.imp[0].video.w).to.equal(width);
expect(data.imp[0].video.h).to.equal(height);
expect(data.imp[0].bidfloor).to.equal(bidRequest.params.bidfloor);
Expand Down Expand Up @@ -567,7 +567,6 @@ describe('OneVideoBidAdapter', function () {
requestId: bidRequest.bidId,
bidderCode: spec.code,
cpm: serverResponse.seatbid[0].bid[0].price,
adId: serverResponse.seatbid[0].bid[0].adid,
creativeId: serverResponse.seatbid[0].bid[0].crid,
vastXml: serverResponse.seatbid[0].bid[0].adm,
width: 640,
Expand Down

0 comments on commit 11017ae

Please sign in to comment.