This repository has been archived by the owner on Nov 23, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 28
Add flag and logic to delete cross domain identifiers #54
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
d143361
Add flag and logic to delete cross domain identifiers
f2prateek b7f2920
update method name from deleteCrossDomainId() -> deleteCrossDomainIdI…
f2prateek e2eb5f3
Independently check and delete cookie and localStorage traits
f2prateek 5521824
add more tests
f2prateek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1087,6 +1087,101 @@ describe('Segment.io', function() { | |
assert.equal(segment.isCrossDomainAnalyticsEnabled(), true); | ||
}); | ||
}); | ||
|
||
describe('deleteCrossDomainId', function() { | ||
it('should not delete cross domain identifiers by default', function() { | ||
segment.cookie('seg_xid', 'test_xid'); | ||
segment.cookie('seg_xid_ts', 'test_xid_ts'); | ||
segment.cookie('seg_xid_fd', 'test_xid_fd'); | ||
analytics.identify({ | ||
crossDomainId: 'test_xid' | ||
}); | ||
|
||
segment.deleteCrossDomainIdIfNeeded(); | ||
|
||
assert.equal(segment.cookie('seg_xid'), 'test_xid'); | ||
assert.equal(segment.cookie('seg_xid_ts'), 'test_xid_ts'); | ||
assert.equal(segment.cookie('seg_xid_fd'), 'test_xid_fd'); | ||
assert.equal(analytics.user().traits().crossDomainId, 'test_xid'); | ||
}); | ||
|
||
it('should do not delete cross domain identifiers if disabled', function() { | ||
segment.options.deleteCrossDomainId = false; | ||
|
||
segment.cookie('seg_xid', 'test_xid'); | ||
segment.cookie('seg_xid_ts', 'test_xid_ts'); | ||
segment.cookie('seg_xid_fd', 'test_xid_fd'); | ||
analytics.identify({ | ||
crossDomainId: 'test_xid' | ||
}); | ||
|
||
segment.deleteCrossDomainIdIfNeeded(); | ||
|
||
assert.equal(segment.cookie('seg_xid'), 'test_xid'); | ||
assert.equal(segment.cookie('seg_xid_ts'), 'test_xid_ts'); | ||
assert.equal(segment.cookie('seg_xid_fd'), 'test_xid_fd'); | ||
assert.equal(analytics.user().traits().crossDomainId, 'test_xid'); | ||
}); | ||
|
||
it('should delete cross domain identifiers if enabled', function() { | ||
segment.options.deleteCrossDomainId = true; | ||
|
||
segment.cookie('seg_xid', 'test_xid'); | ||
segment.cookie('seg_xid_ts', 'test_xid_ts'); | ||
segment.cookie('seg_xid_fd', 'test_xid_fd'); | ||
analytics.identify({ | ||
crossDomainId: 'test_xid' | ||
}); | ||
|
||
segment.deleteCrossDomainIdIfNeeded(); | ||
|
||
assert.equal(segment.cookie('seg_xid'), null); | ||
assert.equal(segment.cookie('seg_xid_ts'), null); | ||
assert.equal(segment.cookie('seg_xid_fd'), null); | ||
assert.equal(analytics.user().traits().crossDomainId, null); | ||
}); | ||
|
||
it('should delete localStorage trait even if only traits exists', function() { | ||
segment.options.deleteCrossDomainId = true; | ||
|
||
analytics.identify({ | ||
crossDomainId: 'test_xid' | ||
}); | ||
|
||
segment.deleteCrossDomainIdIfNeeded(); | ||
|
||
assert.equal(analytics.user().traits().crossDomainId, null); | ||
}); | ||
|
||
it('should delete xid cookie even if only cookie exists', function() { | ||
segment.options.deleteCrossDomainId = true; | ||
|
||
segment.cookie('seg_xid', 'test_xid'); | ||
|
||
segment.deleteCrossDomainIdIfNeeded(); | ||
|
||
assert.equal(segment.cookie('seg_xid'), null); | ||
assert.equal(segment.cookie('seg_xid_ts'), null); | ||
assert.equal(segment.cookie('seg_xid_fd'), null); | ||
}); | ||
|
||
it('should not delete any other traits if enabled', function() { | ||
segment.options.deleteCrossDomainId = true; | ||
|
||
analytics.identify({ | ||
crossDomainId: 'test_xid', | ||
name: 'Prateek', | ||
age: 26 | ||
}); | ||
|
||
segment.deleteCrossDomainIdIfNeeded(); | ||
|
||
assert.deepEqual(analytics.user().traits(), { | ||
name: 'Prateek', | ||
age: 26 | ||
}); | ||
}); | ||
}); | ||
}); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. there could be another test for the case when the cookie doesn't exist but crossDomainId trait in localStorage exists. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. added 2 - one for that and one for reverse. |
||
}); | ||
} | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here we could add
seg_xid_fd
andseg_xid_ts
and then later verify that they are deleted.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added!