Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Nonnull & Nullable annotation to jakarta.annotation #488

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Change Nonnull & Nullable annotation to jakarta.annotation #488

merged 1 commit into from
Sep 16, 2024

Conversation

edsonjab
Copy link
Contributor

@edsonjab edsonjab commented Aug 7, 2024

Fix issue #487

@edsonjab edsonjab mentioned this pull request Aug 7, 2024
Closed
rvowles
rvowles approved these changes Aug 7, 2024
View reviewed changes
Copy link

@rvowles rvowles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep - this is exactly right - including the dep means it won't break anything as well.

@edsonjab edsonjab marked this pull request as ready for review August 8, 2024 23:12
@MichaelGHSeg MichaelGHSeg merged commit 2253257 into segmentio:master Sep 16, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelGHSeg MichaelGHSeg MichaelGHSeg approved these changes

@rvowles rvowles rvowles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edsonjab @rvowles @MichaelGHSeg