This repository has been archived by the owner on May 18, 2021. It is now read-only.
feat: Support "session_ttl" config param in every command (#251) #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Describe how the code actually works, where session-ttl determines the duration of the first SAML assumed AWS role, not the session to Okta.
|
This also includes the README.md update from PR #250, which can be closed if this PR is merged. |
|
@nickatsegment Any comments on this PR? It's pretty straightforward. |
|
@sdann yeah, sorry, I've been slammed with my real job :P We technically are in a code freeze. But seems simple enough, and it only touches internal |
nickatsegment
approved these changes
Dec 17, 2019
This was referenced Dec 17, 2019
|
@nickatsegment Thank you! Luckily my real job this month includes improving |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If "session_ttl" exists in config profile, use it as if --session-ttl was provided on the CLI.
This creates config parity between "session-ttl" and "assume-role-ttl".
I believe only one term is necessary, but we can address that in a later issue.