Skip to content
This repository has been archived by the owner on Apr 3, 2024. It is now read-only.

Add param to method on loadPreference on Preference interface #258

Merged
merged 5 commits into from
Nov 16, 2022
Merged

Add param to method on loadPreference on Preference interface #258

merged 5 commits into from
Nov 16, 2022

Conversation

edsonjab
Copy link
Contributor

@edsonjab edsonjab commented Sep 3, 2022

Solve the issue #257

@nd4p90x nd4p90x linked an issue Sep 7, 2022 that may be closed by this pull request
Missing param for loadPreferences type #257
Closed
chrisradek
chrisradek approved these changes Sep 7, 2022
View reviewed changes
Copy link
Contributor

@chrisradek chrisradek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@nd4p90x nd4p90x added the enhancement New feature or request label Sep 9, 2022
@MichaelGHSeg MichaelGHSeg merged commit f00e4a3 into segmentio:master Nov 16, 2022
@edsonjab edsonjab deleted the add_param_preferences_interface branch April 1, 2023 01:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chrisradek chrisradek chrisradek approved these changes

Assignees

@lalmalani lalmalani

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing param for loadPreferences type
5 participants
@edsonjab @chrisradek @lalmalani @nd4p90x @MichaelGHSeg