This repository has been archived by the owner on Apr 3, 2024. It is now read-only.
Update type for bannerSubContent and subContent #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisradek
reviewed
Sep 14, 2022
| @@ -41,7 +41,7 @@ interface ContainerProps { | |||
| isConsentRequired: boolean | |||
| implyConsentOnInteraction: boolean | |||
| bannerContent: React.ReactNode | |||
| bannerSubContent: React.ReactNode | |||
| bannerSubContent: string | undefined | |||
There was a problem hiding this comment.
I think it might make sense to have the type be React.ReactNode | string. That way you can apply your own styling to the sub-content by wrapping the contents in a span (or even include an img if you really wanted).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #265