Add priority to check tx based on gas fees #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codchen
approved these changes
Sep 22, 2022
baseapp/baseapp.go
Outdated
| @@ -662,7 +662,7 @@ func (app *BaseApp) runTx(ctx sdk.Context, mode runTxMode, txBytes []byte) (gInf | |||
|
|
|||
| // only run the tx if there is block gas remaining | |||
| if mode == runTxModeDeliver && ctx.BlockGasMeter().IsOutOfGas() { | |||
| return gInfo, nil, nil, sdkerrors.Wrap(sdkerrors.ErrOutOfGas, "no block gas left to run tx") | |||
| return gInfo, nil, nil, 0, sdkerrors.Wrap(sdkerrors.ErrOutOfGas, "no block gas left to run tx") | |||
There was a problem hiding this comment.
do we want to set these error cases to -1 so that if some valid txs didn't specify priority and default to 0, at least they won't be ranked after the invalid ones?
| bankKeeper: bk, | ||
| feegrantKeeper: fk, | ||
| txFeeChecker: tfc, |
There was a problem hiding this comment.
if this field is required, we probably want to add it to simapp in this repo to 1 prevent it from breaking and 2 serve as an example
There was a problem hiding this comment.
Added it in the simapp where we create a new AnteHandler in latest commit. However it is not required func NewDeductFeeDecorator(ak AccountKeeper, bk types.BankKeeper, fk FeegrantKeeper, tfc TxFeeChecker) DeductFeeDecorator { if tfc == nil { tfc = CheckTxFeeWithValidatorMinGasPrices }
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on cosmos/cosmos-sdk#11985 and cosmos/cosmos-sdk#12953