Use transform: translate() instead of margin-* for the tooltips. Fix #483

[wismill]

Fix #483 using CSS property transform instead of margin-* for the tooltips.

According to caniuse.com, this property has a very good support in the browsers.

[seiyria]

this would need to pass our full CI suite before we could merge it. You'll also need to follow the contribution guidelines: https://github.com/seiyria/bootstrap-slider/blob/master/.github/CONTRIBUTING.md

You need to add a unit test to replace the one that was taken away, and I would like to see a jsfiddle of this.

[wismill]

Well, it passes the full CI as I did not modify any of the lines reported by codeclimate.
I do follow your contribution guidelines. Please indicate what is not respected.
The unit test does not apply anymore, as the margin of the margins of the tooltips are never modified.

[seiyria]

• It will need to pass code climate, regardless of whether you touched it or not
• You should add a jsfiddle so we can see it in action
• You should add a new unit test in place of the old one.

[wismill]

The issue detected by codeclimate is a duplication between javascript files in src and dist. How can I solve this?

[seiyria]

I'm not sure why it would come up then. Maybe @rovolution knows why? Either way though - the rest applies.

…

On Thu, Nov 2, 2017, 09:39 Wismill ***@***.***> wrote: The issue detected by codeclimate is a duplication between javascript files in src and dist. How can I solve this? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#798 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAum2T-1O_0u_Bns55cbXBTp4LH7Tqxyks5sydQ8gaJpZM4QPs7-> .

[wismill]

JSFiddle:

• Original (see Chrome/Split tooltip on range slider not aligned #483) http://jsfiddle.net/cwssL37d/
• With updated bootstrap-slider : http://jsfiddle.net/5waxge9b/1/. I just removed the link to the js of bootstrap-slider and embedded the new code.

[wismill]

Re-added the test, modified.

[rovolution]

My one concern is that since we state in our docs that we support IE9 and above, this will break that guarantee.

That being said, I would be ok with merging/releasing this, but would want to do so under a major version bump.

[wismill]

It is supported by IE 9 using prefix -ms-. But this will add more code. Or all of this could be managed in CSS by using a class rather than a fixed CSS property using Javascript. I'll check that.

[wismill]

I have simplified the code and added support for IE 9. In fact, your code already uses CSS transform for .slider-handle.triangle and without compatibility.

[rovolution]

The issue detected by codeclimate is a duplication between javascript files in src and dist. How can I solve this?

Yea I agree this is a red-herring error. I added the dist directory contents to the exclude_paths section of the codeclimate config file, so this should prevent any errors coming from that directory going forward.

[rovolution]

merged and released to v10.0.0 (published as a breaking change just incase there any inadvertent regressions). Thanks again for your contribution!