Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue #854 - Range slider, min value over max value. #864

Merged
merged 2 commits into from
Nov 5, 2018

Conversation

jespirit
Copy link
Collaborator

Pull Requests

Please accompany all pull requests with the following (where appropriate):

  • unit tests (we use Jasmine 2.x.x)
  • JSFiddle (or an equivalent such as CodePen, Plunker, etc) or screenshot/GIF with new feature or bug-fix
  • Link to original Github issue (if this is a bug-fix)
  • documentation updates to README file
  • examples within /tpl/index.tpl (for new options being added)
  • Passes CI-server checks (runs automated tests, JS source-code linting, etc..). To run these on your local machine, type grunt test in your Terminal within the bootstrap-slider repository directory

This pull request fixes #854. You can check the issue for my JSFiddle that is used to reproduce the bug.

I added 2 unit tests as well as making a minor edit with a unit test in the same file: test/specs/DraggingHandlesSpec.js.

I will say that I was getting this error Fatal error: Callback must be a function displayed at the very end in red text, after running the unit tests using grunt test command. I don't know why, thoughts?

@seiyria
Copy link
Owner

seiyria commented Oct 24, 2018

The code here looks good. You'll have to figure out how to make codeclimate happy with your tests.

@rovolution do you know what's up with the grunt error?

@rovolution
Copy link
Collaborator

@seiyria personally, im not too picky about fixing the code climate issue, and have debated just removing it altogether since i feel it doesnt deliver any real value TBH.

@seiyria
Copy link
Owner

seiyria commented Oct 25, 2018

@rovolution That's fine with me. I'd rather replace it with a linter if we had that set up or some-such. Or just not have it altogether.

@rovolution
Copy link
Collaborator

we already have a linter setup in our CI check - https://github.com/seiyria/bootstrap-slider/blob/master/Gruntfile.js#L274-L278

@rovolution
Copy link
Collaborator

@jespirit LGTM 👍 ill merge, publish, and update changelog.

@rovolution
Copy link
Collaborator

@jespirit merged and published to v10.2.3.

Thanks again for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Range slider, min value over max value.
3 participants