Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

makes event listener callbacks execute asynchronously #902

Merged
merged 5 commits into from
Jan 6, 2019
Merged

makes event listener callbacks execute asynchronously #902

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b725613
makes event listener callbacks execute asynchronously
rovolution Dec 22, 2018
4055c67
incorporating feedback
rovolution Dec 22, 2018
aa65b48
removes default timeout from async event tests + removes async execut…
rovolution Dec 28, 2018
b189ce3
Remove done callbacks from synchronous tests
jespirit Jan 3, 2019
d441ed4
Edit event repetition tests to use `numTimesFired`
jespirit Jan 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions test/specs/DraggingHandlesSpec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,28 +221,23 @@ describe("Dragging handles tests", function() {
expect(testSlider.getValue()).toEqual([2, 5]);
});

it("Should trigger change on mouseup", function() {
var ups = 0;
it("Should trigger change on mouseup", function(done) {
jespirit marked this conversation as resolved.
Show resolved Hide resolved
var changes = 0;

testSlider.on('slideStop', function(){
expect(changes).toBe(1);
ups++;
expect(testSlider.getValue()).toEqual([2, 5]);
done();
});

testSlider.mousedown(mouseEvent('mousedown', tickOffsets[1]));
expect(testSlider.getValue()).toEqual([1, 5]);
expect(ups).toBe(0);

testSlider.on('change', function(){
expect(ups).toBe(0);
changes++;
});

testSlider.mouseup(mouseEvent('mouseup', tickOffsets[2]));
expect(testSlider.getValue()).toEqual([2, 5]);
expect(changes).toBe(1);
expect(ups).toBe(1);
});

describe("Test 'mousemove' and 'mouseup' produces correct results", function() {
Expand Down
Loading