Fix hang on disconnect of non-compliant devices: Added timeout to RX … #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…path and buffer overflow check.
src/pio_usb.c
Outdated
| pp->usb_rx_buffer[idx++] = data; | ||
| crc_receive = (crc_receive >> 8) | (data << 8); | ||
| crc_receive_inverse = crc_receive ^ 0xffff; | ||
| crc_match = (crc_receive_inverse == crc_prev2); | ||
| } | ||
| } | ||
| if (timeout == 0) { |
There was a problem hiding this comment.
The period between receiving and sending the acknowledgment is time-critical. Could the timeout determination be deferred until after this process?
There was a problem hiding this comment.
Yes as long as the loop doesn't get stuck infinitely and static bool __no_inline_not_in_flash_func(connection_check)(root_port_t *port) gets to see the port it can be wherever, I can move it down after the transaction if the return -1; is even needed, I'll test it out. Would it also be better to use the remainder of int16_t t = 240; at the top of the function for the timer? I wasn't sure how much is expected to be remaining.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed a hang that would happen when disconnecting some devices by adding a timeout to the RX path, I also added an overflow check to the buffer.