rgblight: Enable twinkle mode in rgblight #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rand() returns an integer type value which is usually a very
large value compared with the threshold in the current lottery
logic with uint8_t. Because of this, most of the lottery
fails and no twinkle is observed on the keyboard.
Cherry-picked from the original qmk repository:
571a979
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
rand() returns an integer type value which is usually a very large value compared with the threshold in the current lottery logic with uint8_t. Because of this, most of the lottery fails and no twinkle is observed on the keyboard.
Cherry-picked from the original qmk repository: 571a979
Types of Changes
Issues Fixed or Closed by This PR
Checklist