Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgblight: Enable twinkle mode in rgblight #63

Open
wants to merge 1 commit into
base: dev/ble_micro_pro
Choose a base branch
from

Conversation

yokada-code
Copy link

Description

rand() returns an integer type value which is usually a very large value compared with the threshold in the current lottery logic with uint8_t. Because of this, most of the lottery fails and no twinkle is observed on the keyboard.

Cherry-picked from the original qmk repository: 571a979

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • (none)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

rand() returns an integer type value which is usually a very
large value compared with the threshold in the current lottery
logic with uint8_t. Because of this, most of the lottery
fails and no twinkle is observed on the keyboard.

Cherry-picked from the original qmk repository:
    571a979
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant