PointerVector smart pointer intergration.
#1468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigercosmos
reviewed
Jun 24, 2024
tigercosmos
reviewed
Jun 24, 2024
tigercosmos
reviewed
Jun 24, 2024
tigercosmos
approved these changes
Jun 25, 2024
Dimi1010
commented
Jun 25, 2024
tigercosmos
reviewed
Jun 26, 2024
| @@ -56,7 +56,9 @@ namespace pcpp | |||
| * @param[in] other The vector to move from. | |||
| */ | |||
| PointerVector(PointerVector&& other) noexcept : m_Vector(std::move(other.m_Vector)) | |||
| {} | |||
| { | |||
| other.m_Vector.clear(); | |||
There was a problem hiding this comment.
seems redundant, because when people call moving constructor, they suppose to not to use the object anymore?
There was a problem hiding this comment.
std::vector's move ctor technically does not have a well defined state after move. The standard just says it should be in a valid state, but it does not guarantee it will always be empty state. It usually is, but that is implementation defined.
If for some reason, an implementation left the vector non-empty, the destructor will attempt to iterate through the values and call delete on them.
There was a problem hiding this comment.
I see. thanks for the explanation.
seladb
changed the title
PointerVector smart pointer intergration.
seladb
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Core changes to
PointerVector:pushBackthat acceptsunique_ptr<T>.getAndDetachthat work analogous togetAndRemoveFromVectorbut returnunique_ptr<T>.constoverloads tofront()/back()accessors.nullptris being pushed into the vector.