Refactored clang version check into a python script. #1471
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| import subprocess | ||
|
|
||
| EXPECTED_CLANG_VERSION = "18.1.6" | ||
|
|
||
|
|
||
| def main(): | ||
| result = subprocess.run("clang-format --version", capture_output=True) | ||
|
There was a problem hiding this comment.
|
||
| result.check_returncode() | ||
|
|
||
| version_str = result.stdout.decode("utf-8").split(" ")[2].strip() | ||
|
There was a problem hiding this comment. nit: the default split character is space, so you can just do: There was a problem hiding this comment. Thanks. Updated in de4d3d8 |
||
| if version_str != EXPECTED_CLANG_VERSION: | ||
| print( | ||
| f"Error: Found clang-format version {version_str}, but {EXPECTED_CLANG_VERSION} is required." | ||
| ) | ||
| exit(1) | ||
|
There was a problem hiding this comment. In python the convention is to throw an exception. It's exit value is raise ValueError(f"Error: Found clang-format version {version_str}, but {EXPECTED_CLANG_VERSION} is required.") |
||
|
|
||
| print("Clang format version satisfied.") | ||
| exit(0) | ||
|
There was a problem hiding this comment. This line is not needed. The default exit value is |
||
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| main() | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
explicitly use Python3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure.
subprocess.runis not supported pre python 3.5 anyway.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed aabbbba