Fix crash with parseuntil when top layer is more than the chosen parseuntil OSI layer. #1580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…euntil OSI layer.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1580 +/- ##
==========================================
- Coverage 82.91% 82.90% -0.01%
==========================================
Files 273 273
Lines 46261 46274 +13
Branches 9412 9343 -69
==========================================
+ Hits 38356 38365 +9
- Misses 7049 7105 +56
+ Partials 856 804 -52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
seladb
approved these changes
Sep 19, 2024
tigercosmos
approved these changes
Sep 21, 2024
tigercosmos
pushed a commit
to tigercosmos/PcapPlusPlus
that referenced
this pull request
Sep 24, 2024
…euntil OSI layer. (seladb#1580) * Fix crash with parseuntil when top layer is more than the chosen parseuntil OSI layer. * fix format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix crash with pcpp::Packet parseuntil of OSI layer that is less than the top layer in the packet.