Remove ifdef inside cpp and format #1587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree, it's better to manage this at CMake. |
clementperon
force-pushed
the
clean_ifdef
branch
2 times, most recently
from
0660506
to
697e27d
Compare
clementperon
force-pushed
the
clean_ifdef
branch
from
697e27d
to
6fc1cf5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1587 +/- ##
==========================================
- Coverage 82.90% 82.90% -0.01%
==========================================
Files 273 273
Lines 46278 46277 -1
Branches 9287 9536 +249
==========================================
- Hits 38367 38365 -2
+ Misses 7100 7076 -24
- Partials 811 836 +25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
clementperon
changed the title
tigercosmos
approved these changes
Sep 22, 2024
Dimi1010
approved these changes
Sep 22, 2024
seladb
approved these changes
Sep 24, 2024
tigercosmos
pushed a commit
to tigercosmos/PcapPlusPlus
that referenced
this pull request
Sep 24, 2024
* Remove ifdef inside cpp * Proper indent file * More fix * same for headers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should let CMake choose if this CPP should be compiled or not