Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to Alpine 3.20, Fedora 40, FreeBSD 13.4 and 14.1 #1588

Merged
merged 4 commits into from
Sep 24, 2024

Conversation

clementperon
Copy link
Collaborator

No description provided.

@clementperon clementperon changed the title Bump to Alpine 3.20 Bump to Alpine 3.20 and Fedora 40 Sep 22, 2024
@clementperon clementperon changed the title Bump to Alpine 3.20 and Fedora 40 Bump to Alpine 3.20, Fedora 40, FreeBSD 13.4 and 14.1 Sep 22, 2024
Copy link
Collaborator

@Dimi1010 Dimi1010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Made a couple of comments on the changes in the cpp, but they aren't critical.

Pcap++/src/PcapLiveDevice.cpp Show resolved Hide resolved
Pcap++/src/PcapLiveDevice.cpp Show resolved Hide resolved
Pcap++/src/PcapLiveDevice.cpp Show resolved Hide resolved
Copy link

codecov bot commented Sep 22, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.90%. Comparing base (3b57224) to head (e5f6911).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
Pcap++/src/PcapLiveDevice.cpp 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1588   +/-   ##
=======================================
  Coverage   82.90%   82.90%           
=======================================
  Files         273      273           
  Lines       46278    46278           
  Branches     9287     9300   +13     
=======================================
+ Hits        38367    38368    +1     
+ Misses       7100     7069   -31     
- Partials      811      841   +30     
Flag Coverage Δ
fedora39 ?
fedora40 74.40% <ø> (?)
macos-12 80.89% <66.66%> (ø)
macos-13 80.30% <66.66%> (ø)
macos-14 80.23% <66.66%> (ø)
mingw32 70.27% <ø> (-0.02%) ⬇️
mingw64 70.24% <ø> (-0.01%) ⬇️
npcap 84.81% <ø> (-0.02%) ⬇️
rhel94 74.26% <ø> (ø)
ubuntu2004 57.83% <ø> (ø)
ubuntu2004-zstd 57.95% <ø> (ø)
ubuntu2204 74.22% <ø> (+0.03%) ⬆️
ubuntu2204-icpx 58.40% <ø> (+<0.01%) ⬆️
ubuntu2404 74.49% <ø> (+0.04%) ⬆️
unittest 82.90% <66.66%> (+<0.01%) ⬆️
windows-2019 84.86% <ø> (-0.02%) ⬇️
windows-2022 84.86% <ø> (-0.02%) ⬇️
winpcap 84.84% <ø> (ø)
xdp 49.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@tigercosmos tigercosmos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but maybe we should do the upgrade before the release though. 😂

@tigercosmos tigercosmos merged commit 26ced48 into seladb:dev Sep 24, 2024
135 checks passed
tigercosmos pushed a commit to tigercosmos/PcapPlusPlus that referenced this pull request Sep 24, 2024
* Bump to Alpine 3.20

* Bump to Fedora 40

* ci: bump FreeBSD to 13.4 and 14.1

* pcap++: pcaplivedevice avoid variable-length arrays
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants