Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where math would not compile correctly in LESS version #36

Merged
merged 1 commit into from
Jun 6, 2016
Merged

Fix bug where math would not compile correctly in LESS version #36

merged 1 commit into from
Jun 6, 2016

Conversation

lway
Copy link

@lway lway commented Mar 24, 2016

Math in LESS won't be done unless it's surrounded by parenthesis. The result of compiling the LESS currently is something like "padding: 6px 12px + 4px*3 6px 6px". This fixes that issue.

@fk
Copy link
Member

fk commented Jun 1, 2016

Hi @lway, thanks for contributing!

I'm working on the next release and just compiled the Less sources (lessc --verbose src/build.less tmp/select2-bootstrap-theme-less.css using lessc v2.7.1). The code in question in your pull request is still present in my current version and I don't seem to run into any problems – which really makes me wonder what the difference between our build environments is. May I ask what version of the Less compiler you are using?

@trappar
Copy link

trappar commented Jun 2, 2016

I work with lway and we're on 2.6.0. Updating to 2.7.1 does fix the issue. It seems like this change is preferable for backwards compatibility and readability though.

@fk
Copy link
Member

fk commented Jun 3, 2016

Hi @trappar, thanks for coming back so quick. I will merge the pull request (and port changes to Sass) – good to know that the issue is fixed in the latest version though!

@fk fk added this to the 0.1.0-beta.6 milestone Jun 6, 2016
@fk fk merged commit 97dfdcd into select2:master Jun 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants