Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor DBaaS resources #251

Merged
merged 6 commits into from
May 15, 2024

Conversation

Gogen120
Copy link
Contributor

@Gogen120 Gogen120 commented Feb 13, 2024

  • Added new package waiters with wait function for DBaaS resources
  • Remove redundant usage of selMutexKV
  • Remove usage of flag ForceNew with False value as it is a default value
  • Replace an old MinTimeout value with calculated value on production
  • Add fl_size and invalid_values fields for Flavor and ConfigurationParameters data sources, respectively
  • Moved DBaaS resource schemas to the separate files schema_selectel_dbaas_*

@Gogen120 Gogen120 force-pushed the dbaas_resources_refactoring branch 2 times, most recently from 2a4ec5c to ed96b1e Compare February 28, 2024 17:22
@Gogen120 Gogen120 force-pushed the dbaas_resources_refactoring branch 2 times, most recently from 71d723f to f28dd56 Compare April 18, 2024 08:43
- Added new package waiters with wait function for DBaaS resources
- Remove redundant usage of selMutexKV
- Remove usage of flag ForceNew with False value as it is a default
value
- Replace an old MinTimeout value with calculated value on production
- Add fl_size and invalid_values fields for Flavor and
ConfigurationParameters data sources, respectively
- Add base schemas for datastore and database resources
- Add required fields for each datastore type in corresponding schema
instead of deleting unused fields
- Use Sensitive: true for password fields
Copy link
Collaborator

@TawR1024 TawR1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kolsean kolsean merged commit cfc3f26 into selectel:master May 15, 2024
2 checks passed
@Gogen120 Gogen120 deleted the dbaas_resources_refactoring branch September 20, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants