Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling under iOS #1127

Merged
merged 1 commit into from
Aug 10, 2016
Merged

Improve handling under iOS #1127

merged 1 commit into from
Aug 10, 2016

Conversation

zeitiger
Copy link
Contributor

@zeitiger zeitiger commented Aug 8, 2016

Under iOS

  • Open selectize widget with closeAfterSelection: true
  • Onscreen keyboard appears
  • Select something (independent of keyboard usage)
  • Selectize close correctly, but onscreen keyboard keeps open

This pull request fix this issue, with removing focus on hidden text input field, within close event handling.

@coveralls
Copy link

coveralls commented Aug 8, 2016

Coverage Status

Changes Unknown when pulling 4436954 on zeitiger:master into * on selectize:master*.

@coveralls
Copy link

coveralls commented Aug 8, 2016

Coverage Status

Changes Unknown when pulling 3bb3453 on zeitiger:master into * on selectize:master*.

@joallard
Copy link
Member

joallard commented Aug 8, 2016

Thanks. The UX makes a lot of sense to me in the scenario you describe. I'm just wary about adding yet another option. Is there a way we can make the default better?

@joallard
Copy link
Member

joallard commented Aug 8, 2016

Yep. Actually, having tried this on iOS, having the keyboard still out after selection makes no sense. Let's make this default behavior.

However, the control input must only lose focus in a case like this, where we have a select. When we have an input, the dropdown should close, but the control must not lose focus. I think we'd need to enumerate the use cases to provide solid defaults.

@joallard joallard added this to the 0.13.0 milestone Aug 8, 2016
@zeitiger
Copy link
Contributor Author

zeitiger commented Aug 9, 2016

After I get the broken test, I thought that focus thing was as designed, why else would be assertion for this detail ;-)

Yes to lose focus within tag mode make no sense, I only use this widget for a improved vanilla select.

So next step, I kick out the option and check that we are on single mode and made a selection and has closeAfterSelection: true. Is that okay for you?

btw. thanks for your work here, I really appreciate your positiv response 😸

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling e9dd293 on zeitiger:master into * on selectize:master*.

@joallard
Copy link
Member

joallard commented Aug 9, 2016

Squash that with a concise/descriptive commit message, and we'll be good for a merge

@joallard
Copy link
Member

joallard commented Aug 9, 2016

Also, don't forget to add a Changelog line!

- tweak handling under iOS
- improve blur handling and add option
- improve pullrequest based on helpful feedback
- change CHANGELOG
@zeitiger
Copy link
Contributor Author

done

@coveralls
Copy link

coveralls commented Aug 10, 2016

Coverage Status

Changes Unknown when pulling 4be1964 on zeitiger:master into * on selectize:master*.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants