Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add message signing feature and tweak firmware sig verification #106

Merged
6 commits merged into from
Mar 21, 2022

Conversation

ghost
Copy link

@ghost ghost commented Mar 21, 2022

Resolves #104

Splits out Sign PSBT into Sign with a submenu where you can sign a PSBT or Message.

Tweaks how the firmware verifies signatures to support this kind of signature.

@codecov
Copy link

codecov bot commented Mar 21, 2022

Codecov Report

Merging #106 (e4d14a9) into main (e80f5d4) will decrease coverage by 0.26%.
The diff coverage is 88.52%.

@@            Coverage Diff             @@
##             main     #106      +/-   ##
==========================================
- Coverage   96.07%   95.80%   -0.27%     
==========================================
  Files          22       22              
  Lines        1810     1861      +51     
==========================================
+ Hits         1739     1783      +44     
- Misses         71       78       +7     
Impacted Files Coverage Δ
src/krux/key.py 95.55% <75.00%> (-4.45%) ⬇️
src/krux/pages/home.py 97.31% <88.63%> (-2.69%) ⬇️
src/krux/firmware.py 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@ghost ghost merged commit 2888dc3 into main Mar 21, 2022
@ghost ghost deleted the message-signing branch March 21, 2022 17:17
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add message signing
0 participants