Add SYS_EXC_INFO for micropython to handle exceptions #96
Conversation
|
Thanks! (By the way, the comment-coverage test failing was unrelated to your change) |
ghost
merged commit 
logging.py uses sys.exc_info() in exception handling, for that MICROPY_PY_SYS_EXC_INFO needs to be enabled on micropython port, otherwise system may crash.
|
Your welcome! (One of the motivation of this tiny PR was check if it would succeed, as I'm trying to make cleaner contributions) |
|
@odudex So, I think this change may be redundant. Did you run into an issue due to it not being in |
|
I did run into issues without this.
It was during tests, another error I did raised an exception. Without
this the system would crash, with this the exception was presented at
device screen.
Em seg, 7 de mar de 2022 01:59, Jeff ***@***.***> escreveu:
… @odudex <https://github.com/odudex>
Update:
I'm currently working on breaking out my changes to MaixPy into their own
repo and submodule (to resolve #78
<#78>), and I just noticed that I
already made this change within the micropython core config here:
https://github.com/jreesun/krux/blob/main/firmware/MaixPy/components/micropython/core/py/mpconfig.h#L1153
So, I think this change may be redundant. Did you run into an issue due to
it not being in mpconfigport.h? If not, I may remove this change from my
fork if it's unnecessary.
—
Reply to this email directly, view it on GitHub
<#96 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABGQZBW5MVMLGYKFX73WDK3U6WEK7ANCNFSM5P6FAL5Q>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Okay, good to know. I'll leave it as-is then, thank you! |
logging.py uses sys.exc_info() in exception handling, for that MICROPY_PY_SYS_EXC_INFO needs to be enabled on micropython port, otherwise system may crash.