Skip to content

Commit

Permalink
[Bugfix] Fix incorrect conditions added in longer entries (sonic-net#…
Browse files Browse the repository at this point in the history
…14955)

In PR sonic-net#14912, we added conditions to longer matching entries in conditional marks. We got some mistakes while adding conditions into some longer entries. In this PR, we fix these mistakes.
  • Loading branch information
yutongzhang-microsoft authored Oct 11, 2024
1 parent ffbf8b5 commit cceb07f
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,8 @@ bfd/test_bfd.py::test_bfd_basic:
and not supported for platforms other than Nvidia 4600c/4700/5600. Skipping the test"
conditions_logical_operator: or
conditions:
- "platform in ['x86_64-8102_64h_o-r0', 'x86_64-8101_32fh_o-r0', 'x86_64-8111_32eh_o-r0', 'x86_64-8122_64eh_o-r0', 'x86_64-8122_64ehf_o-r0', 'x86_64-mlnx_msn4600c-r0', 'x86_64-mlnx_msn4700-r0', 'x86_64-nvidia_sn5600-r0']"
- "platform in ['x86_64-8102_64h_o-r0', 'x86_64-8101_32fh_o-r0', 'x86_64-8111_32eh_o-r0', 'x86_64-8122_64eh_o-r0', 'x86_64-8122_64ehf_o-r0']"
- "platform not in ['x86_64-mlnx_msn4600c-r0', 'x86_64-mlnx_msn4700-r0', 'x86_64-nvidia_sn5600-r0', 'x86_64-8102_64h_o-r0', 'x86_64-8101_32fh_o-r0']"
- "release in ['201811', '201911']"

bfd/test_bfd.py::test_bfd_scale:
Expand All @@ -89,7 +90,8 @@ bfd/test_bfd.py::test_bfd_scale:
and not supported for platforms other than Nvidia 4600c/4700/5600. Skipping the test"
conditions_logical_operator: or
conditions:
- "platform in ['x86_64-8102_64h_o-r0', 'x86_64-8101_32fh_o-r0', 'x86_64-8111_32eh_o-r0', 'x86_64-8122_64eh_o-r0', 'x86_64-8122_64ehf_o-r0', 'x86_64-mlnx_msn4600c-r0', 'x86_64-mlnx_msn4700-r0', 'x86_64-nvidia_sn5600-r0']"
- "platform in ['x86_64-8102_64h_o-r0', 'x86_64-8101_32fh_o-r0', 'x86_64-8111_32eh_o-r0', 'x86_64-8122_64eh_o-r0', 'x86_64-8122_64ehf_o-r0']"
- "platform not in ['x86_64-mlnx_msn4600c-r0', 'x86_64-mlnx_msn4700-r0', 'x86_64-nvidia_sn5600-r0', 'x86_64-8102_64h_o-r0', 'x86_64-8101_32fh_o-r0']"
- "release in ['201811', '201911']"

bfd/test_bfd_static_route.py:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -776,9 +776,11 @@ platform_tests/mellanox:

platform_tests/mellanox/test_check_sfp_using_ethtool.py:
skip:
reason: "Deprecated as Mellanox do not use ethtool in release 202305 or higher"
reason: "Deprecated as Mellanox do not use ethtool in release 202305 or higher / Mellanox platform tests only supported on Mellanox devices"
conditions_logical_operator: or
conditions:
- "asic_type in ['mellanox']"
- "asic_type not in ['mellanox', 'nvidia-bluefield']"

platform_tests/mellanox/test_reboot_cause.py:
skip:
Expand Down

0 comments on commit cceb07f

Please sign in to comment.