Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update FedX template #49

Open
wants to merge 7 commits into
base: devel
Choose a base branch
from
Open

Update FedX template #49

wants to merge 7 commits into from

Conversation

antru6
Copy link
Member

@antru6 antru6 commented Dec 3, 2021 •
edited
Loading

Updates:

  • Use alpine 3.7 for base image
  • Configure FedX not to issue ASK queries to the endpoints
  • Rename and update the yaml template file
  • Create an additional experiment for toybench for fedx

@stasinos stasinos requested a review from gmouchakis December 4, 2021 05:43
@acharal
Copy link
Member

acharal commented Dec 4, 2021

As I see it, disabling by default the ASK queries will provide misleading results to whomever uses this template. In other words there is no indication that this is a fedx template with a custom configuration.

@antru6
Copy link
Member Author

antru6 commented Dec 6, 2021

I have renamed the template into "fedx-noask-template" so that it is obvious that FedX is configured to use SELECT instead of ASK queries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmouchakis gmouchakis Awaiting requested review from gmouchakis

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antru6 @acharal