Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: define retry limit in retry config #693

Merged
merged 1 commit into from
Sep 9, 2023

Conversation

dhensby
Copy link
Contributor

@dhensby dhensby commented Sep 8, 2023

Potential fix to #644

The current retry logic attempts to see if the retry limit has been hit but it does this by checking against an undefined value.

This may have been an oversight from #487 as RETRY_CONFIG did have a retries property, but it was removed.

@dhensby dhensby changed the title fix: define retry limit is defined in retry config fix: define retry limit in retry config Sep 9, 2023
Copy link
Member

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be! Let's try! Thanks!

@gr2m gr2m merged commit 5ad0486 into semantic-release:master Sep 9, 2023
5 checks passed
@github-actions
Copy link

github-actions bot commented Sep 9, 2023

🎉 This PR is included in version 9.0.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants