Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: verify OAuth scopes of classic GitHub PATs #897

Merged
merged 10 commits into from
Sep 2, 2024
Merged

feat: verify OAuth scopes of classic GitHub PATs #897

merged 10 commits into from
Sep 2, 2024

Conversation

jedwards1211
Copy link
Contributor

Solves #895 for classic PATs only

babblebey
babblebey approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@babblebey babblebey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @jedwards1211

Thank you 🫶

Though waiting on the test coverage, but I'm approving this yea 😁

@babblebey babblebey changed the title fix: verify OAuth scopes of classic GitHub PATs feat: verify OAuth scopes of classic GitHub PATs Sep 2, 2024
@babblebey babblebey merged commit be071a2 into semantic-release:master Sep 2, 2024
6 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 2, 2024

🎉 This issue has been resolved in version 10.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jedwards1211
Copy link
Contributor Author

Yay thanks! Please ping me if anyone reports issues with this and I don't notice, if anything comes up I'll fix it. The experience with the repo renames makes me nervous 😅

@babblebey
Copy link
Member

Sure thing @jedwards1211.... and yooooo we noticed you've been very active around our project for some time now and your contributions are of great value.

We'd therefore like to invite you as an additional maintainer for the GitHub plugin (this way you can surely get the pings auto-magically haha 😃)

Would that be something you're interested in??? 😉

Cc: @gr2m

@babblebey babblebey linked an issue Sep 2, 2024 that may be closed by this pull request
Feature request: precheck more permissions needed by other steps in verify step #895
Open
@jedwards1211
Copy link
Contributor Author

Yeah that sounds good! Do y'all have any kind of meetings to plan things together?

@dominykas dominykas mentioned this pull request Sep 5, 2024
Closed
babblebey added a commit that referenced this pull request Sep 5, 2024
@babblebey
Revert "feat: verify OAuth scopes of classic GitHub PATs (#897)"
9d75403 
This reverts commit be071a2.
@babblebey babblebey mentioned this pull request Sep 5, 2024
Merged
@oscard0m oscard0m mentioned this pull request Sep 13, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@babblebey babblebey babblebey approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: precheck more permissions needed by other steps in verify step
2 participants
@jedwards1211 @babblebey