Skip to content

Commit

Permalink
[SecuritySolution] Unskip fullscreen timeline tests (elastic#174593)
Browse files Browse the repository at this point in the history
## Summary

Unskips the fullscreen timeline tests.

Looking at the issue described in
elastic#172547, it appears that the
timeline was somehow not opening correctly in some cases. This flakiness
has been removed in elastic#173413, so it
should be possible to unskip these tests.

In addition to unskipping the tests, an unnecessary task execution was
removed and two force clicks were cleaned up.

[Flaky test
runner](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4834)
(200/200)

fixes elastic#172547
  • Loading branch information
janmonschke authored and semd committed Jan 12, 2024
1 parent 21b92cf commit e241ae8
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,14 @@ import {
enterFullScreenMode,
exitFullScreenMode,
} from '../../../tasks/security_main';
import { populateTimeline } from '../../../tasks/timeline';

import { hostsUrl } from '../../../urls/navigation';

describe.skip('Toggle full screen', { tags: ['@ess', '@serverless'] }, () => {
describe('Toggle full screen', { tags: ['@ess', '@serverless'] }, () => {
beforeEach(() => {
login();
visitWithTimeRange(hostsUrl('allHosts'));
openTimelineUsingToggle();
populateTimeline();
});

it('Should hide timeline header and tab list area', () => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,9 @@ export const closeTimelineUsingCloseButton = () => {
};

export const enterFullScreenMode = () => {
cy.get(TIMELINE_FULL_SCREEN_BUTTON).first().click({ force: true });
cy.get(TIMELINE_FULL_SCREEN_BUTTON).first().click();
};

export const exitFullScreenMode = () => {
cy.get(TIMELINE_EXIT_FULL_SCREEN_BUTTON).first().click({ force: true });
cy.get(TIMELINE_EXIT_FULL_SCREEN_BUTTON).first().click();
};

0 comments on commit e241ae8

Please sign in to comment.