New Published Rules - harishumasankar18_personal_org.detect-new-function #3526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![semgrep-dev-pr-bot[bot]](https://avatars.githubusercontent.com/in/60337?s=60&v=4){kind=small}
0xDC0DE
reviewed
Dec 11, 2024
| let res = `with(a='${activity}', hp=${health}, w=${weight}, hs=${happiness}) { | ||
| if (a == 'feed') { hp += 1; w += 5; hs += 3; } if (a == 'play') { w -= 5; hp += 2; hs += 3; } if (a == 'sleep') { hp += 2; w += 3; hs += 3; } if ((a == 'feed' || a == 'sleep' ) && w > 70) { hp -= 10; hs -= 10; } else if ((a == 'feed' || a == 'sleep' ) && w < 40) { hp += 10; hs += 5; } else if (a == 'play' && w < 40) { hp -= 10; hs -= 10; } else if ( hs > 70 && (hp < 40 || w < 30)) { hs -= 10; } if ( hs > 70 ) { m = 'kissy' } else if ( hs < 40 ) { m = 'cry' } else { m = 'awkward'; } if ( hs > 100) { hs = 100; } if ( hs < 5) { hs = 5; } if ( hp < 5) { hp = 5; } if ( hp > 100) { hp = 100; } if (w < 10) { w = 10 } return {m, hp, w, hs} | ||
| }`; | ||
| quickMaths = new Function(res); |
There was a problem hiding this comment.
Suggested change
| quickMaths = new Function(res); | |
| //ruleid: detect-new-function | |
| quickMaths = new Function(res); | |
0xDC0DE
requested changes
Dec 11, 2024
There was a problem hiding this comment.
Thanks for your contribution @harish36000 !
It looks like you are missing some test syntax, as well as some of the metadata is not passing our rule lints. I have made some suggestions.
Comment on lines
+15
to
+24
| cwe: | ||
| - 'CWE 94: Improper Control of Generation of Code (''Code Injection'')' | ||
| owasp: | ||
| - A3:2021 Injection | ||
| technology: | ||
| - javascript | ||
| references: | ||
| - https://nvd.nist.gov/vuln/detail/cve-2023-23623 | ||
| subcategory: | ||
| - guardrail |
There was a problem hiding this comment.
Suggested change
| cwe: | |
| - 'CWE 94: Improper Control of Generation of Code (''Code Injection'')' | |
| owasp: | |
| - A3:2021 Injection | |
| technology: | |
| - javascript | |
| references: | |
| - https://nvd.nist.gov/vuln/detail/cve-2023-23623 | |
| subcategory: | |
| - guardrail | |
| cwe: | |
| - 'CWE-94: Improper Control of Generation of Code (''Code Injection'')' | |
| owasp: | |
| - A3:2021 Injection | |
| technology: | |
| - javascript | |
| references: | |
| - https://nvd.nist.gov/vuln/detail/cve-2023-23623 | |
| subcategory: | |
| - secure default |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wahoo! New published rules with
harishumasankar18_personal_org.detect-new-functionfrom @harish36000.See semgrep.dev/s/6J7pB for more details.
Thanks for your contribution! ❤️