-
Notifications
You must be signed in to change notification settings - Fork 613
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: cli does not notify app when scan has an exception (semgrep/semg…
…rep-proprietary#2393) Previously if a scan throws an exception, the app will miss the notification and it will look like the scan is still in progress in the app even though the CLI had already failed. This PR fixes that. Tested by added more assertions in our current tests. Before this PR, these new assertions would fail. After this PR, these assertions pass. Closes SMS-540 synced from Pro 2db8c9d524c4f6a43abad4a2b77686bd32a2b4ed
- Loading branch information
Showing
3 changed files
with
44 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
When a scan runs into an exception, the app is appropriately notified | ||
about the failure. Previously, in the app, it would seem to the user | ||
that the scan is still in progress. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters